diff --git a/plugin.xml b/plugin.xml index cba35fc..fd25600 100644 --- a/plugin.xml +++ b/plugin.xml @@ -11,7 +11,7 @@ - + diff --git a/readme.md b/readme.md index 58fcaed..9797652 100644 --- a/readme.md +++ b/readme.md @@ -23,11 +23,11 @@ You can read more about it on [Android official website](https://source.android. ```javascript - cordova.exec(function success(signature){ - //Check signature - }, function failure(error){ - //alert("Something went wrong"); - }, "ReadAppSignature", "getAppSignature", []); + cordova.plugins.ReadAppSignature.getAppSignature(function(signature){ + console.debug("signature: %s", signature); + }, function(error){ + console.debug("signature error: %s", JSON.stringify(error)); + }); ``` diff --git a/src/android/ReadAppSignature.java b/src/android/ReadAppSignature.java index 6c06011..40ebd45 100644 --- a/src/android/ReadAppSignature.java +++ b/src/android/ReadAppSignature.java @@ -1,12 +1,13 @@ package cordova.plugin.appSignature; +import android.util.Log; + import org.apache.cordova.CordovaPlugin; import org.apache.cordova.CallbackContext; import org.apache.cordova.PluginResult; import org.json.JSONArray; import org.json.JSONException; -import org.json.JSONObject; import android.annotation.SuppressLint; import android.content.pm.PackageInfo; @@ -22,6 +23,7 @@ import java.security.NoSuchProviderException; * This class echoes a string called from JavaScript. */ public class ReadAppSignature extends CordovaPlugin { + private final String TAG = "ReadAppSignature"; @Override public boolean execute(String action, JSONArray args, CallbackContext callbackContext) throws JSONException { @@ -46,9 +48,10 @@ public class ReadAppSignature extends CordovaPlugin { cordova.getActivity().getPackageName(), PackageManager.GET_SIGNATURES); //note sample just checks the first signature - for (Signature signature : packageInfo.signatures) { - // SHA1 the signature - LogUtils.LOGD(TAG, "getAppSignature() called : " + getSHA1(signature.toByteArray())); + Signature[] signatures = packageInfo.signatures; + if (signatures.length > 0) { + Signature signature = signatures[0]; + Log.d(TAG, "getAppSignature() called : " + getSHA1(signature.toByteArray())); return getSHA1(signature.toByteArray()); } } catch (PackageManager.NameNotFoundException e) { diff --git a/www/ReadAppSignature.js b/www/ReadAppSignature.js index 7440283..215255a 100644 --- a/www/ReadAppSignature.js +++ b/www/ReadAppSignature.js @@ -1,5 +1,5 @@ var exec = require('cordova/exec'); -exports.getAppSignature = function (arg0, success, error) { - exec(success, error, 'ReadAppSignature', 'getAppSignature', [arg0]); +exports.getAppSignature = function (success, error) { + exec(success, error, 'ReadAppSignature', 'getSignature', []); };