From d71557892bc9f031eefcd338f337713921906b1e Mon Sep 17 00:00:00 2001 From: wux Date: Thu, 29 Nov 2018 11:08:04 +0800 Subject: [PATCH 1/6] change java file target path --- plugin.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin.xml b/plugin.xml index cba35fc..fd25600 100644 --- a/plugin.xml +++ b/plugin.xml @@ -11,7 +11,7 @@ - + From 0cd4f4d83de1f7ada34c43c985b35917e4145e11 Mon Sep 17 00:00:00 2001 From: wux Date: Thu, 29 Nov 2018 11:09:39 +0800 Subject: [PATCH 2/6] remove LogUtils; add TAG --- src/android/ReadAppSignature.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/android/ReadAppSignature.java b/src/android/ReadAppSignature.java index 6c06011..40ebd45 100644 --- a/src/android/ReadAppSignature.java +++ b/src/android/ReadAppSignature.java @@ -1,12 +1,13 @@ package cordova.plugin.appSignature; +import android.util.Log; + import org.apache.cordova.CordovaPlugin; import org.apache.cordova.CallbackContext; import org.apache.cordova.PluginResult; import org.json.JSONArray; import org.json.JSONException; -import org.json.JSONObject; import android.annotation.SuppressLint; import android.content.pm.PackageInfo; @@ -22,6 +23,7 @@ import java.security.NoSuchProviderException; * This class echoes a string called from JavaScript. */ public class ReadAppSignature extends CordovaPlugin { + private final String TAG = "ReadAppSignature"; @Override public boolean execute(String action, JSONArray args, CallbackContext callbackContext) throws JSONException { @@ -46,9 +48,10 @@ public class ReadAppSignature extends CordovaPlugin { cordova.getActivity().getPackageName(), PackageManager.GET_SIGNATURES); //note sample just checks the first signature - for (Signature signature : packageInfo.signatures) { - // SHA1 the signature - LogUtils.LOGD(TAG, "getAppSignature() called : " + getSHA1(signature.toByteArray())); + Signature[] signatures = packageInfo.signatures; + if (signatures.length > 0) { + Signature signature = signatures[0]; + Log.d(TAG, "getAppSignature() called : " + getSHA1(signature.toByteArray())); return getSHA1(signature.toByteArray()); } } catch (PackageManager.NameNotFoundException e) { From 32e11f19f24bd56a1312cc06faaae0f26338d09d Mon Sep 17 00:00:00 2001 From: wux Date: Thu, 29 Nov 2018 11:12:41 +0800 Subject: [PATCH 3/6] fix wrong parameter --- www/ReadAppSignature.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/ReadAppSignature.js b/www/ReadAppSignature.js index 7440283..215255a 100644 --- a/www/ReadAppSignature.js +++ b/www/ReadAppSignature.js @@ -1,5 +1,5 @@ var exec = require('cordova/exec'); -exports.getAppSignature = function (arg0, success, error) { - exec(success, error, 'ReadAppSignature', 'getAppSignature', [arg0]); +exports.getAppSignature = function (success, error) { + exec(success, error, 'ReadAppSignature', 'getSignature', []); }; From 2094dfd22e7e59f6d8c1cfc76b268691c32d088f Mon Sep 17 00:00:00 2001 From: wux Date: Thu, 29 Nov 2018 11:15:39 +0800 Subject: [PATCH 4/6] modify 'Usage' --- readme.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/readme.md b/readme.md index 58fcaed..df79ff1 100644 --- a/readme.md +++ b/readme.md @@ -23,11 +23,11 @@ You can read more about it on [Android official website](https://source.android. ```javascript - cordova.exec(function success(signature){ - //Check signature - }, function failure(error){ - //alert("Something went wrong"); - }, "ReadAppSignature", "getAppSignature", []); + cordova.plugins.ReadAppSignature.getAppSignature(function(signature){ + console.debug("signature: %s", signature); + }, function(error){ + console.debug("signature error: %s", JSON.stringify(error)); + }); ``` From dd4b3fcb6ceea033d84c4e1b1c0aa1686e94972c Mon Sep 17 00:00:00 2001 From: wux Date: Thu, 29 Nov 2018 11:17:22 +0800 Subject: [PATCH 5/6] intent use space --- readme.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/readme.md b/readme.md index df79ff1..81bd9f1 100644 --- a/readme.md +++ b/readme.md @@ -24,10 +24,10 @@ You can read more about it on [Android official website](https://source.android. ```javascript cordova.plugins.ReadAppSignature.getAppSignature(function(signature){ - console.debug("signature: %s", signature); + console.debug("signature: %s", signature); }, function(error){ - console.debug("signature error: %s", JSON.stringify(error)); - }); + console.debug("signature error: %s", JSON.stringify(error)); + }); ``` From 5c711d62afce7ca2230973ab8e3f9da523910fae Mon Sep 17 00:00:00 2001 From: wux Date: Thu, 29 Nov 2018 11:18:10 +0800 Subject: [PATCH 6/6] intent use space --- readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.md b/readme.md index 81bd9f1..9797652 100644 --- a/readme.md +++ b/readme.md @@ -25,7 +25,7 @@ You can read more about it on [Android official website](https://source.android. cordova.plugins.ReadAppSignature.getAppSignature(function(signature){ console.debug("signature: %s", signature); - }, function(error){ + }, function(error){ console.debug("signature error: %s", JSON.stringify(error)); });