From fcea9cad44b94a33fa8876b24ea79fcec02fa36a Mon Sep 17 00:00:00 2001 From: Pierre-Olivier Latour Date: Wed, 9 Apr 2014 13:53:46 -0700 Subject: [PATCH] Moved +shouldAutomaticallyMapHEADToGET to GCDWebServer class --- CGDWebServer/GCDWebServer.h | 1 + CGDWebServer/GCDWebServer.m | 4 ++++ CGDWebServer/GCDWebServerConnection.h | 1 - CGDWebServer/GCDWebServerConnection.m | 6 +----- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CGDWebServer/GCDWebServer.h b/CGDWebServer/GCDWebServer.h index 2570b81..32e03ee 100644 --- a/CGDWebServer/GCDWebServer.h +++ b/CGDWebServer/GCDWebServer.h @@ -63,6 +63,7 @@ NSString* GCDWebServerGetPrimaryIPv4Address(); // Returns IPv4 address of prima @interface GCDWebServer (Subclassing) + (Class)connectionClass; + (NSString*)serverName; // Default is class name ++ (BOOL)shouldAutomaticallyMapHEADToGET; // Default is YES which means HEAD requests are mapped to GET requests with the response body being discarded @end @interface GCDWebServer (Extensions) diff --git a/CGDWebServer/GCDWebServer.m b/CGDWebServer/GCDWebServer.m index 445ab78..5705c25 100644 --- a/CGDWebServer/GCDWebServer.m +++ b/CGDWebServer/GCDWebServer.m @@ -510,6 +510,10 @@ static void _NetServiceClientCallBack(CFNetServiceRef service, CFStreamError* er return NSStringFromClass(self); } ++ (BOOL)shouldAutomaticallyMapHEADToGET { + return YES; +} + @end @implementation GCDWebServer (Extensions) diff --git a/CGDWebServer/GCDWebServerConnection.h b/CGDWebServer/GCDWebServerConnection.h index 366c5c8..0f139c4 100644 --- a/CGDWebServer/GCDWebServerConnection.h +++ b/CGDWebServer/GCDWebServerConnection.h @@ -40,7 +40,6 @@ @end @interface GCDWebServerConnection (Subclassing) -+ (BOOL)shouldAutomaticallyMapHEADToGET; // Default is YES which means HEAD requests are mapped to GET requests with the response body being discarded - (void)open; - (void)didUpdateBytesRead; // Called from arbitrary thread after @totalBytesRead is updated - Default implementation does nothing - (void)didUpdateBytesWritten; // Called from arbitrary thread after @totalBytesWritten is updated - Default implementation does nothing diff --git a/CGDWebServer/GCDWebServerConnection.m b/CGDWebServer/GCDWebServerConnection.m index 5ae3b37..7798598 100644 --- a/CGDWebServer/GCDWebServerConnection.m +++ b/CGDWebServer/GCDWebServerConnection.m @@ -535,7 +535,7 @@ static inline NSUInteger _ScanHexNumber(const void* bytes, NSUInteger size) { if (extraData) { NSString* requestMethod = ARC_BRIDGE_RELEASE(CFHTTPMessageCopyRequestMethod(_requestMessage)); // Method verbs are case-sensitive and uppercase DCHECK(requestMethod); - if ([[self class] shouldAutomaticallyMapHEADToGET] && [requestMethod isEqualToString:@"HEAD"]) { + if ([[_server class] shouldAutomaticallyMapHEADToGET] && [requestMethod isEqualToString:@"HEAD"]) { requestMethod = @"GET"; _virtualHEAD = YES; } @@ -662,10 +662,6 @@ static NSString* _StringFromAddressData(NSData* data) { @implementation GCDWebServerConnection (Subclassing) -+ (BOOL)shouldAutomaticallyMapHEADToGET { - return YES; -} - - (void)open { LOG_DEBUG(@"Did open connection on socket %i", _socket); [self _readRequestHeaders];