From 35bfe40d9e9d00887c49f9aa7763b112a2373f37 Mon Sep 17 00:00:00 2001 From: Ibrahim Hadeed Date: Thu, 10 Mar 2016 15:27:01 -0500 Subject: [PATCH] refactor(batterystatus): extract getObservable() from class extracted the getObservable() function from class so it doesn't show as a method (in docs and auto-complete) --- src/plugins/batterystatus.ts | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/plugins/batterystatus.ts b/src/plugins/batterystatus.ts index 9912ed58e..510eed59c 100644 --- a/src/plugins/batterystatus.ts +++ b/src/plugins/batterystatus.ts @@ -34,7 +34,7 @@ export class BatteryStatus { * @returns {Observable} Returns an observable that pushes a status object */ static onChange () : Observable { - return BatteryStatus.getObservable("batterylevel"); + return getEventObservable("batterylevel"); } /** @@ -42,7 +42,7 @@ export class BatteryStatus { * @returns {Observable} Returns an observable that pushes a status object */ static onLow () : Observable { - return BatteryStatus.getObservable("batterylow"); + return getEventObservable("batterylow"); } /** @@ -50,20 +50,7 @@ export class BatteryStatus { * @returns {Observable} Returns an observable that pushes a status object */ static onCritical () : Observable { - return BatteryStatus.getObservable("batterycritical"); - } - - /** - * Wrap the event with an observable - * @param event - * @returns {Observable} - */ - static getObservable (event : string) : Observable { - return new Observable(observer => { - let callback = (status : any) => observer.next(status); - window.addEventListener(event, callback, false); - return () => window.removeEventListener(event, callback, false); - }); + return getEventObservable("batterycritical"); } } @@ -78,4 +65,17 @@ interface StatusObject { * A boolean that indicates whether the device is plugged in */ isPlugged : boolean +} + +/** + * Wrap the event with an observable + * @param event + * @returns {Observable} + */ +function getEventObservable (event : string) : Observable { + return new Observable(observer => { + let callback = (status : any) => observer.next(status); + window.addEventListener(event, callback, false); + return () => window.removeEventListener(event, callback, false); + }); } \ No newline at end of file