From 40b9295de64e27c652f58fa37a4bb50c6bc2cdc4 Mon Sep 17 00:00:00 2001 From: Calum Murray Date: Tue, 23 Jun 2020 17:58:22 +0100 Subject: [PATCH] fix(launch-review): Allow rating() callback to be invoked multiple times (#3455) --- src/@ionic-native/plugins/launch-review/index.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/@ionic-native/plugins/launch-review/index.ts b/src/@ionic-native/plugins/launch-review/index.ts index 69a244298..94bb0ae67 100644 --- a/src/@ionic-native/plugins/launch-review/index.ts +++ b/src/@ionic-native/plugins/launch-review/index.ts @@ -1,5 +1,6 @@ import { Injectable } from '@angular/core'; import { Cordova, IonicNativePlugin, Plugin } from '@ionic-native/core'; +import { Observable } from 'rxjs'; /** * @name Launch Review @@ -55,10 +56,10 @@ export class LaunchReview extends IonicNativePlugin { * - First: after `LaunchReview.rating()` is called and the request to show the dialog is successful. Will be passed the value `requested`. * - Second: if and when the Rating dialog is actually displayed. Will be passed the value `shown`. * - Third: if and when the Rating dialog is dismissed. Will be passed the value `dismissed`. - * @returns {Promise} + * @returns {Observable} */ - @Cordova({ platforms: ['iOS'] }) - rating(): Promise { + @Cordova({ observable: true }) + rating(): Observable { return; }