From babfb0dca3eb32f672062ddd8ed2b2a545c394f4 Mon Sep 17 00:00:00 2001 From: Ramon Henrique Ornelas Date: Wed, 12 Oct 2016 23:51:57 -0300 Subject: [PATCH 1/3] fix(onesignal): update to match latest API version (#691) --- src/plugins/onesignal.ts | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/plugins/onesignal.ts b/src/plugins/onesignal.ts index ec878e4c9..f3c234954 100644 --- a/src/plugins/onesignal.ts +++ b/src/plugins/onesignal.ts @@ -1,7 +1,6 @@ import { Cordova, Plugin } from './plugin'; import { Observable } from 'rxjs/Observable'; - /** * @name OneSignal * @description @@ -16,7 +15,7 @@ import { Observable } from 'rxjs/Observable'; * * OneSignal.startInit('b2f7f966-d8cc-11e4-bed1-df8f05be55ba', '703322744261'); * - * OneSignal.enableInAppAlertNotification(true); + * OneSignal.inFocusDisplaying(OneSignal.OSInFocusDisplayOption.InAppAlert); * * OneSignal.handleNotificationReceived().subscribe(() => { * // do something when notification is received @@ -38,7 +37,7 @@ import { Observable } from 'rxjs/Observable'; export class OneSignal { /** - * @private + * constants to use in inFocusDisplaying() */ static OSInFocusDisplayOption = { None: 0, @@ -172,17 +171,13 @@ export class OneSignal { static enableSound(enable: boolean): void { } /** - * Warning: - * Only applies to Android and Amazon devices. * - * By default this is false and notifications will not be shown when the user is in your app, instead the notificationOpenedCallback is fired. - * If set to true notifications will always show in the notification area and notificationOpenedCallback will not fire until the user taps on the notification. + * Setting to control how OneSignal notifications will be shown when one is received while your app is in focus. By default this is set to inAppAlert, which can be helpful during development. * - * @param {boolean} enable + * @param {number} displayOption Options are 0 = None, 1 = InAppAlert, and 2 = Notification. */ @Cordova({ sync: true }) - static enableNotificationsWhenActive(enable: boolean): void { } - + static inFocusDisplaying(displayOption: number): void { } /** * You can call this method with false to opt users out of receiving all notifications through OneSignal. From 43c8592b4093aceebd0626cc3609c4c45939fe39 Mon Sep 17 00:00:00 2001 From: Ramon Henrique Ornelas Date: Wed, 12 Oct 2016 23:52:27 -0300 Subject: [PATCH 2/3] style(file): fix angular style (#685) --- src/plugins/file.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/file.ts b/src/plugins/file.ts index 7528afb1c..c58179719 100644 --- a/src/plugins/file.ts +++ b/src/plugins/file.ts @@ -1,4 +1,4 @@ -import {Plugin, pluginWarn} from './plugin'; +import { Plugin, pluginWarn } from './plugin'; declare var window: any; declare var cordova: any; From 74a252b3246c6aab25197fed53de4e747e9d10a3 Mon Sep 17 00:00:00 2001 From: Colin Frick Date: Fri, 14 Oct 2016 01:00:15 +0200 Subject: [PATCH 3/3] fix(googlemaps): Expose 'type' property in GoogleMapsLatLngBounds #693 (#694) --- src/plugins/googlemaps.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/googlemaps.ts b/src/plugins/googlemaps.ts index f2b20c065..2cccc1771 100644 --- a/src/plugins/googlemaps.ts +++ b/src/plugins/googlemaps.ts @@ -885,6 +885,7 @@ export class GoogleMapsLatLngBounds { @InstanceProperty get northeast(): GoogleMapsLatLng { return; } @InstanceProperty get southwest(): GoogleMapsLatLng { return; } + @InstanceProperty get type(): string { return; } constructor(southwestOrArrayOfLatLng: GoogleMapsLatLng | GoogleMapsLatLng[], northeast?: GoogleMapsLatLng) { let args = !!northeast ? [southwestOrArrayOfLatLng, northeast] : southwestOrArrayOfLatLng;