From fbd523f36a7214b1e933cca8765fece744ea8192 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=BDeljko=20Brckovi=C4=87?= Date: Tue, 11 Jul 2023 19:25:29 +0200 Subject: [PATCH] fix(mobile-messaging): fix event (un)register and saveUser (#4569) Fix methods for registering and unregistering events and improve comments. Also make return type for saveUser more descriptive. --- .../plugins/mobile-messaging/index.ts | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/@awesome-cordova-plugins/plugins/mobile-messaging/index.ts b/src/@awesome-cordova-plugins/plugins/mobile-messaging/index.ts index c74875041..e721d0d2c 100644 --- a/src/@awesome-cordova-plugins/plugins/mobile-messaging/index.ts +++ b/src/@awesome-cordova-plugins/plugins/mobile-messaging/index.ts @@ -328,16 +328,19 @@ export class MobileMessaging extends AwesomeCordovaNativePlugin { * @param event */ @Cordova({ - observable: true, + sync: true, }) - register(event: Event): Observable { + register(event: Event, handler: Function): void { return; } + /** + * Alias for `register`. + */ @Cordova({ - observable: true, + sync: true, }) - on(event: Event): Observable { + on(event: Event, handler: Function): void { return; } @@ -350,16 +353,19 @@ export class MobileMessaging extends AwesomeCordovaNativePlugin { * @param {Function} handler will be unregistered from event */ @Cordova({ - observable: true, + sync: true, }) - unregister(event: Event): Observable { + unregister(event: Event, handler: Function): void { return; } + /** + * Alias for `unregister`. + */ @Cordova({ - observable: true, + sync: true, }) - off(event: Event): Observable { + off(event: Event, handler: Function): void { return; } @@ -419,7 +425,7 @@ export class MobileMessaging extends AwesomeCordovaNativePlugin { * @param {Object} userData. An object containing user data */ @Cordova() - saveUser(userData: UserData): Promise { + saveUser(userData: UserData): Promise { return; }