Commit Graph

55 Commits

Author SHA1 Message Date
Matt Lewis f3e698f1be feat(instagram): add instagram sharing plugin (#453)
Closes #307
2016-08-19 09:08:05 -04:00
Kevin Boosten 4e87ac72ea fix(): add the reject function at the expected errorIndex position in the args array (#436)
We don't want that the reject cb takes the position of an optional
argument that has not been defined
For example the Dialogs.alert method takes an optional 'buttonLabel'
string. In case we do not set this value, and thus want to use the
default value, the 'reject'
callback get spliced into this position due the fact that the splice
start index is bigger than the array length.
Dialogs.alert("title", "message", "My button text") --> args =
["title",  resolve, "message", "My button text", reject]
Dialogs.alert("title", "message") -->  args = ["title", resolve,
"message", reject] --> reject is on the position of the buttontitle!

The cordova-plugin-dialogs alert function receives the wrong arguments
—> alert: function(message, completeCallback, title, buttonLabel)
The buttonLabel will receive the "reject" callback instead of a
undefined value.
2016-08-17 07:34:11 -04:00
Matt Lewis 817a4340e7 fix(ng1): use $q promises instead of the native Promise (#378) 2016-07-31 14:24:56 -04:00
Guillermo 7952f9ef60 Improvements on documentation (#340)
* Improvements on documentation and some refactor

* ts | js -> typescript (docs)
2016-07-20 11:17:09 -04:00
Ibby Hadeed 5979e9a8b0 refactor(plugin): refreactor to match tslint rules 2016-07-18 11:39:53 -04:00
Ibrahim Hadeed 0aee6c88ce feat(otherPromise): can work better with plugins that return promises (#304) 2016-07-18 10:51:39 -04:00
Guille 8d82aff41f refactor(plugin): 2016-07-17 20:04:06 +02:00
Ibby Hadeed 4841f31a92 refactor(project): fix and optimize observables 2016-07-17 08:54:39 -04:00
Max Lynch be1725d2eb chore(comments): explain sync 2016-07-14 10:42:56 -05:00
Ibrahim Hadeed 9e3a866ba3 refactor(plugin): cleanup 2016-06-11 10:35:41 -04:00
Ibrahim Hadeed d624a37f55 refactor(plugin): get rid of TS error in IDE 2016-06-11 10:20:28 -04:00
Ibrahim Hadeed 4b121520dd Merge pull request #207 from driftyco/new-contacts
New contacts
2016-06-10 19:38:17 -04:00
Max Lynch 28e2f731f7 fix(plugin) only call clearFunction if defined. Fixes #210 2016-06-10 14:00:41 -05:00
Ibrahim Hadeed 411e6fc2a1 tweaks to make contact plugin work better 2016-06-10 01:10:50 -04:00
Ibrahim Hadeed 2d36c6b812 fix @InstanceProperty decorator, duplicate of get is set 2016-06-09 23:12:23 -04:00
Max Lynch af8fbde892 feat(angular1): Support Angular 1 2016-06-09 11:24:38 -05:00
Ibrahim Hadeed e708653136 change rxjs/Rxjs to rxjs/Observable 2016-06-03 10:05:07 -04:00
Ibrahim Hadeed 9987fb24da refractor Observable imports 2016-05-20 16:59:18 -04:00
glecaros 9ddde5762d Reimplemented using CordovaInstance.
Fixed wrapInstance signature to match how it is called.
2016-05-14 00:33:27 -07:00
Ibrahim Hadeed 28d7d5ceec feat(plugin): add wrapper for instance properties
this wrapper will be able to handle get/set functions for any instance property
2016-04-30 13:31:10 -04:00
Ibrahim Hadeed 06146b322f chore(tslint): add tslint & clean up code 2016-04-29 23:56:49 -04:00
Ibrahim Hadeed 2efce5dcb7 refactor(-): cleanup 2016-04-29 21:50:09 -04:00
Ibrahim Hadeed 94a8a296c1 fix(instance-wrapper): 2016-04-29 21:46:35 -04:00
Ibrahim Hadeed 0b15a2f037 merge 2016-04-29 20:07:59 -04:00
Tim Lancina db07768133 fix(plugin): handle rejection when Cordova is undefined
Zone.js now (helpfully) throws an error on unhandled rejections in
promises. This is great because they no longer silently fail, but we
were relying on that behavior for the case where the plugin isn't
installed or Cordova isn't available. With this change, those cases
won't throw an unhandled rejection error, but all regular plugin errors
still should.
2016-04-27 13:00:59 -05:00
Ibrahim Hadeed 4070991f67 fix(plugin): remove unecessary code 2016-04-25 07:19:43 -04:00
Ibrahim Hadeed a37a041538 style(plugin): reverse previous commit, to keep track of changes easier 2016-04-25 06:22:17 -04:00
Ibrahim Hadeed eea70ffc0a style(plugin.ts): format/indent 2016-03-29 17:53:51 -04:00
Ibrahim Hadeed 5a8d48ea36 perf(ionicnative): instance wrapper cleanup and optimization 2016-03-29 17:49:53 -04:00
Ibrahim Hadeed 0ec737aa49 feat(ionicnative): add instance wrapper
closes https://github.com/driftyco/ionic-native/issues/86

https://github.com/driftyco/ionic-native/issues/79
2016-03-29 06:50:03 -04:00
Ibrahim Hadeed 0d1bd1335f feat(plugin): add event wrapper 2016-03-13 15:30:21 -04:00
Ibrahim Hadeed 9293689649 docs(plugin): set docs to private
to hide in ionic-site
2016-03-12 18:52:25 -05:00
Ibrahim Hadeed a1bdff6b24 docs(plugins): update docs and plugin params 2016-03-12 18:30:16 -05:00
Ibrahim Hadeed c144b87e13 refactor: added semi-columns 2016-03-06 15:27:26 -05:00
Tim Lancina 1334f60b68 fix(plugin): don't call reject when sync 2016-03-06 08:34:05 -06:00
Tim Lancina fc54fefde5 feat(plugin): proxy plugin properties
Rename RequiresPlugin decorator to CordovaProperty and replace getter so
we can forward property access to the underlying plugin property.
2016-03-04 13:56:28 -06:00
Tim Lancina f360827b20 chore(): comment out debug statements 2016-03-04 13:53:59 -06:00
Tim Lancina c48a851d87 feat(plugin): show instructions if plugin not installed 2016-03-04 13:52:57 -06:00
Tim Lancina 240f0f87cc fix(plugin): return originalMethod return value 2016-02-16 17:43:00 -06:00
Tim Lancina 17e3827831 feat(plugin): add sync option to @Cordova for sync functions 2016-02-09 14:45:57 -06:00
Tim Lancina c2fdf39089 fix(plugin): use call for id based clearFunction 2016-02-08 13:07:26 -06:00
Tim Lancina 8f27fc9e51 feat(plugin): call clearFunction with original fn args 2016-02-08 12:42:42 -06:00
Tim Lancina 6fcba5cc3f chore(): fix plugin callback order comment 2016-02-06 16:30:10 -06:00
Tim Lancina bf28669e1a chore(): update rxjs 2016-02-05 15:05:46 -06:00
Max Lynch fb1e2e83da ng1 magic 2015-12-01 13:33:08 -06:00
Max Lynch c939ae975f DEMO with output 2015-11-30 14:38:52 -06:00
Max Lynch 118da948cb awww yis 2015-11-30 13:27:25 -06:00
Max Lynch 2d70c6a3d4 Yea toast 2015-11-30 12:34:54 -06:00
Max Lynch b6e612209a 🧈 2015-11-30 11:09:50 -06:00
Max Lynch af5b3de227 :derp: 2015-11-29 21:50:58 -06:00