github/cordova-android
4
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2026-04-23 00:00:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: drop q module (#833)

Browse Source 
* chore: drop q module
* chore: fix & complete dropping q
* Fix faulty transformation of Q.when
* Simplify thenResolve transformation
  * Removes unnecesary Promise wrapping in onFulfilled callback.
* Transform .done calls to .then or .catch
  * The important thing is that we always handle rejections.
* Remove Q from specs
Requires Jasmine 3.5
* Replace Q.timeout w/ Promise.race & custom function

Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
This commit is contained in:
エリス
2020-01-07 21:22:59 +09:00
committed by GitHub
parent fd57909730
commit 0e6ad28e56
19 changed files with 68 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/unit/builders/ProjectBuilder.spec.js
+1 -1
View File
@@ -201,7 +201,7 @@ describe('ProjectBuilder', () => {
const testError = 'failed to find target with hash string';
ProjectBuilder.__set__('check_reqs', checkReqsSpy);
checkReqsSpy.check_android_target.and.returnValue(Promise.resolve());
checkReqsSpy.check_android_target.and.resolveTo();
execaSpy.and.rejectWith(testError);
return builder.build({}).then(