From 23fd0982b0faa6b7e169c2946eab07930f1f4d16 Mon Sep 17 00:00:00 2001 From: Pierre-Alexis de Solminihac Date: Fri, 22 Apr 2016 19:10:49 +0200 Subject: [PATCH] replace Integer.parseInt with BigInteger so that you can use longer Android version codes I used to have DNS like version codes (YYYYmmmddXX format) for my apps builds, and I can't go back in older apps because Google Play wont allow me to upload inferior version codes, so I thing we should to use BigInteger instead of Integer.parseInt This closes #298 --- bin/templates/project/build.gradle | 2 +- framework/cordova.gradle | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/templates/project/build.gradle b/bin/templates/project/build.gradle index 0aad300c..0ec49a99 100644 --- a/bin/templates/project/build.gradle +++ b/bin/templates/project/build.gradle @@ -164,7 +164,7 @@ android { } defaultConfig { - versionCode cdvVersionCode ?: Integer.parseInt("" + privateHelpers.extractIntFromManifest("versionCode")) + versionCode cdvVersionCode ?: new BigInteger("" + privateHelpers.extractIntFromManifest("versionCode")) applicationId privateHelpers.extractStringFromManifest("package") if (cdvMinSdkVersion != null) { diff --git a/framework/cordova.gradle b/framework/cordova.gradle index 746b63a2..21a01bb5 100644 --- a/framework/cordova.gradle +++ b/framework/cordova.gradle @@ -125,7 +125,7 @@ def doExtractIntFromManifest(name) { def pattern = Pattern.compile(name + "=\"(\\d+)\"") def matcher = pattern.matcher(manifestFile.getText()) matcher.find() - return Integer.parseInt(matcher.group(1)) + return new BigInteger(matcher.group(1)) } def doExtractStringFromManifest(name) {