CB-10618 Handle gradle frameworks on plugin installation/uninstallation

This closes #259
2026-05-30 00:00:04 +08:00 · 2016-02-17 16:37:58 +03:00
parent 7233931681
commit 7be9e880c2
7 changed files with 132 additions and 9 deletions
@@ -0,0 +1,87 @@
+/**
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+*/
+/* jshint laxcomma:true */
+
+require("promise-matchers");
+
+var create = require("../../bin/lib/create");
+
+describe("create", function () {
+  describe("validatePackageName", function() {
+    var valid = [
+        "org.apache.mobilespec"
+      , "com.example"
+      , "com.floors42.package"
+      , "ball8.ball8.ball8ball"
+    ];
+    var invalid = [
+        ""
+      , "com.class.is.bad"
+      , "0com.example.mobilespec"
+      , "c-m.e@a!p%e.mobilespec"
+      , "notenoughdots"
+      , ".starts.with.a.dot"
+      , "ends.with.a.dot."
+      , "_underscore.anything"
+      , "underscore._something"
+      , "_underscore._all._the._things"
+      , "8.ball"
+      , "8ball.ball"
+      , "ball8.8ball"
+      , "ball8.com.8ball"
+    ];
+
+    valid.forEach(function(package_name) {
+      it("should accept " + package_name, function(done) {
+        expect(create.validatePackageName(package_name)).toHaveBeenResolved(done);
+      });
+    });
+
+    invalid.forEach(function(package_name) {
+      it("should reject " + package_name, function(done) {
+        expect(create.validatePackageName(package_name)).toHaveBeenRejected(done);
+      });
+    });
+  });
+  describe("validateProjectName", function() {
+    var valid = [
+        "mobilespec"
+      , "package_name"
+      , "PackageName"
+      , "CordovaLib"
+    ];
+    var invalid = [
+        ""
+      , "0startswithdigit"
+      , "CordovaActivity"
+    ];
+
+    valid.forEach(function(project_name) {
+      it("should accept " + project_name, function(done) {
+        expect(create.validateProjectName(project_name)).toHaveBeenResolved(done);
+      });
+    });
+
+    invalid.forEach(function(project_name) {
+      it("should reject " + project_name, function(done) {
+        expect(create.validateProjectName(project_name)).toHaveBeenRejected(done);
+      });
+    });
+  });
+});
@@ -0,0 +1,77 @@
+/**
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    'License'); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+*/
+
+/* jshint node:true */
+
+var Q = require('q');
+var os = require('os');
+var path = require('path');
+var common = require('cordova-common');
+
+var AndroidProject = require('../../bin/templates/cordova/lib/AndroidProject');
+var builders = require('../../bin/templates/cordova/lib/builders/builders');
+
+var PluginInfo = common.PluginInfo;
+
+var FIXTURES = path.join(__dirname, '../e2e/fixtures');
+var FAKE_PROJECT_DIR = path.join(os.tmpdir(), 'plugin-test-project');
+
+describe('addPlugin method', function () {
+    var api, fail, gradleBuilder;
+
+    beforeEach(function() {
+        var ActionStack = jasmine.createSpyObj('ActionStack', ['createAction', 'push', 'process']);
+        ActionStack.process.andReturn(Q());
+        spyOn(common, 'ActionStack').andReturn(ActionStack);
+
+        spyOn(AndroidProject, 'getProjectFile')
+            .andReturn(jasmine.createSpyObj('AndroidProject', ['getPackageName', 'write']));
+
+        var Api = require('../../bin/templates/cordova/Api');
+        api = new Api('android', FAKE_PROJECT_DIR);
+
+        spyOn(api, '_addModulesInfo');
+        spyOn(api._munger, 'add_plugin_changes')
+            .andReturn(jasmine.createSpyObj('munger', ['save_all']));
+
+        fail = jasmine.createSpy('fail');
+        gradleBuilder = jasmine.createSpyObj('gradleBuilder', ['prepBuildFiles']);
+        spyOn(builders, 'getBuilder').andReturn(gradleBuilder);
+    });
+
+    it('should call gradleBuilder.prepBuildFiles for every plugin with frameworks', function(done) {
+        api.addPlugin(new PluginInfo(path.join(FIXTURES, 'cordova-plugin-fake')))
+        .catch(fail)
+        .fin(function () {
+            expect(fail).not.toHaveBeenCalled();
+            expect(gradleBuilder.prepBuildFiles).toHaveBeenCalled();
+            done();
+        });
+    });
+
+    it('shouldn\'t trigger gradleBuilder.prepBuildFiles for plugins without android frameworks', function(done) {
+        api.addPlugin(new PluginInfo(path.join(FIXTURES, 'cordova-plugin-fake-ios-frameworks')))
+        .catch(fail)
+        .fin(function () {
+            expect(fail).not.toHaveBeenCalled();
+            expect(gradleBuilder.prepBuildFiles).not.toHaveBeenCalled();
+            done();
+        });
+    });
+});