github/cordova-android
4
0
Fork 1
mirror of https://github.com/apache/cordova-android.git synced 2026-04-04 00:02:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use custom Gradle properties to read minSdkVersion value from config.xml (#655)

Browse Source 
Co-authored-by: エリス <ellis.bryan@gmail.com>
Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
This commit is contained in:
Chris Brody
2019-02-12 20:11:32 -05:00
committed by GitHub
parent 719acd3ab1
commit 867da56e2e
3 changed files with 29 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/unit/config/GradlePropertiesParser.spec.js
View File

@@ -74,7 +74,7 @@ describe('Gradle Builder', () => {
});
});
describe('_configureDefaults method', () => {
describe('_configureProperties method', () => {
let parser;
let emitSpy;
@@ -99,11 +99,11 @@ describe('Gradle Builder', () => {
get: getSpy
};
parser._configureDefaults();
parser._configureProperties(parser._defaults);
expect(getSpy).toHaveBeenCalled();
expect(setSpy).toHaveBeenCalled();
expect(emitSpy.calls.argsFor(0)[1]).toContain('Appended missing default');
expect(emitSpy.calls.argsFor(0)[1]).toContain('Appending configuration item');
});
it('should not detect missing defaults and not call set.', () => {
@@ -115,7 +115,7 @@ describe('Gradle Builder', () => {
get: getSpy
};
parser._configureDefaults();
parser._configureProperties(parser._defaults);
expect(getSpy).toHaveBeenCalled();
expect(setSpy).not.toHaveBeenCalled();
@@ -130,7 +130,7 @@ describe('Gradle Builder', () => {
get: getSpy
};
parser._configureDefaults();
parser._configureProperties(parser._defaults);
expect(getSpy).toHaveBeenCalled();
expect(setSpy).not.toHaveBeenCalled();