* GH-1156: Restore key event handlers when a DOM element is fullscreen
Make sure to call dispatchKeyEvent from base class in WrapperView, if
the event hasn't been handled by the engine.
* Remove unwanted whitespace in condition
Co-authored-by: エリス <erisu@users.noreply.github.com>
Co-authored-by: Michael Goffioul <michael.goffioul@lincor.com>
* (android) #1002: Add Null Pointer Checks to prevent Cordova from running on a destroyed activity
* (android) Add logging statements if Cordova Activity does not exist anymore (i.e. is destroyed)
Co-authored-by: Habets Rick <rick.habets@kbc.be>
* try to allow changing min sdk version
* undo testing with cdvMinSdkVersion=21
* Update framework/build.gradle
No printing of default behaviour
Co-authored-by: Norman Breau <norman@nbsolutions.ca>
* Update framework/build.gradle
typo + match case of cdvMinSdkVersion
Co-authored-by: Norman Breau <norman@nbsolutions.ca>
* resolve PR feedback timbru
Co-authored-by: Norman Breau <norman@nbsolutions.ca>
This commit does the following:
- Makes ANDROID_SDK_ROOT the primary variable to look for the Android SDK location.
- Makes ANDROID_HOME the fallback variable, if ANDROID_SDK_ROOT is not present/valid.
Gradle updates:
Note that the following gradle updates were required, otherwise the android gradle plugin did not honour the ANDROID_SDK_ROOT variable.
- Updates the framework's android studio's gradle plugin from version 3.3.0 to 3.5.3.
Not only this is required for android's gradle to obey ANDROID_SDK_ROOT, it is now in sync with the Android test project/
- Updates the Androidx test project to use gralde plugin from version 3.3.0 to 3.5.3, to match Android Test & framework.
- Consequentially, this required to also upgrade AndroidX test project to use Gradle 6.1, which also matches both the Android test project & framework
These changes above fixes#949
Additionally, since we update the environment variables dynamically, the environment variable printout produced misleading information.
The environment variable printout will now print out the variable as defined by the user (before the tooling messes with them). An additional log
is printed that tells the user exactly what Cordova is going to use for the Android SDK path. This should fix#670
* (android) wrap custom view in FrameLayout
Wraps the custom view in a FrameLayout in order
to capture key events and redirect them to SystemWebView's
dispatchKeyEvent.
* Update framework/src/org/apache/cordova/CordovaWebViewImpl.java
Co-Authored-By: エリス <erisu@users.noreply.github.com>
* Update framework/src/org/apache/cordova/CordovaWebViewImpl.java
Co-Authored-By: エリス <erisu@users.noreply.github.com>
* Update framework/src/org/apache/cordova/CordovaWebViewImpl.java
Co-Authored-By: エリス <erisu@users.noreply.github.com>
* remove empty line below @override
Co-authored-by: Norman Breau <norman@normanbreau.com>
Co-authored-by: エリス <erisu@users.noreply.github.com>
* feat: bump minSdkVersion to 22
BREAKING CHANGE: drop KitKat support
* chore: remove obsolete comment
* feat: remove pre-Lollipop specific code
* chore: remove KitKat from needsKitKatContentUrlFix
* chore: other minor cleanup
* feat: Add support for GoogleServicesEnabled preference option
* fix: wrap google-services classpath with GoogleServicesEnabled flag
* chore: bump google-services version to 4.2.0
* feat: Add support for GoogleServicesVersion preference option
Co-authored-by: Maksim Chemerisuk <chemerisuk@users.noreply.github.com>
* (android) increased default target sdk to 29
* Updated travis and appveyor to use build tools/api level 29
* Fixed two other files that was missing the API 29 update
