From 3f1ee620880a41d8c3dbc595d996f8be7703b2f2 Mon Sep 17 00:00:00 2001
From: Sefa Ilkimen <sefa.ilkimen@mobisys.de>
Date: Fri, 16 Feb 2018 02:50:35 +0100
Subject: [PATCH] add some specs

---
 CHANGELOG.md                                  |   2 +-
 .../www/certificates/httpbin.org.cer          | Bin 0 -> 1294 bytes
 test/app-test-definitions.js                  |  24 +++++++++++++++++-
 3 files changed, 24 insertions(+), 2 deletions(-)
 create mode 100644 test/app-template/www/certificates/httpbin.org.cer

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6548658..b49a36d 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,7 +3,7 @@
 ## 1.10.1
 
 - Fixed #71: does not encode query string in URL correctly on Android
-- Fixed #72: app crashes if response encoding is not UTF-8
+- Fixed #72: app crashes if response encoding is not UTF-8 (thanks jkfb)
 
 ## 1.10.0
 
diff --git a/test/app-template/www/certificates/httpbin.org.cer b/test/app-template/www/certificates/httpbin.org.cer
new file mode 100644
index 0000000000000000000000000000000000000000..cc00688f8643d9376710f694bf4aa748d056d954
GIT binary patch
literal 1294
zcmXqLV&yVuV*a#%nTe5!Nr?HK{;N>iH7P#3zxKX0{8t?D$$*!QQ>)FR?K>|cBR4C9
zftMk-0Vf-CC<~h~Q)sZEn1Kk0!zIk?lUkx)tl*lLTvS<5VyJAO2oh%&mO>F%a4ap!
z$S=w)sZ@wCHjoqNHMB4=G&D3aHa0i1i~@5_;9LVSLlFZZh%ww5B_#z(nR$BoMd=1j
zj7rGPVq|4tZerwT0E%-lH8C<WoY}tS!BY0m%O=mV-EiU6j+eU&UPfK5EM1%YW|5w$
zTgv?Q7#q&FP2v{Uk_<{y`R&5k9gi%kzO<_M-|qW5ng?DkTeL32T=`^&(vs^9-O=lH
z)H6a)KNfwIaPpkTZN7T(TNCcqmgqn5IT7-?W^ujzjR!)f!Z&kv>57#1-c@2f7c2As
z#LFw+7G-r@&<`*XQrxn{ymnF~4>PluVw6T?>;G@t?$<5fRG_N(SN)>=NyS4P(XZBj
zdfD{5ulV!1&gF9h9=%Xz_`c|VtYCrTyp%V0BEmJf+l4J8r)1Z;{3^+ib=JMkecPU4
zrN#ffsRw>M?>(5nz4NR^__9qQ{b5Vl=f2VT6Bo|J%*epFxQR)|povMsfDaggviyvU
z|5;d=nOGMX$b$H)ETEX<&}L&~Wo2h(gtM3octFy^AmvO33=qY9EMhDoa}4*{`2_9~
z=x%&8@8TKRyqf)Y_ZY~76f3hx7>G59tnkW8W~sfq>)A!i?aN$K-+x~5W}!ho%w$GJ
zmSlrO13ehufU!*p6sK1D`uWMl1$vozCAt;HdO4{j#i@`q1deKbxO%2GWvKe()S?m`
z>h%rOK`s(xQ818eLQXSH{N?54ddP{W@gGQ~0!!mJgT~JW9BgdqjXaD@j0TO**tmhg
z!ot{e9~cTi{xt(Nm?M}N#iU@4C@98oY~yOULMDU8c|47?Lozap6`X<Y%}mQoPAo}P
z$W5$N$j{5ER7gryC`!%AOifWJEy&MPNUBr_O3kUv%u81YNCYZREmla(OMxiO%u`5A
zPR=h%Nz6-5RVdFa$xtZCNJTL=AU`KFxl$o5zZ9q`u|xsn$YNm7q6MdZQEEYcab`(=
zQKdd|4gzLuU=Ctr;F%N7m8v)Qwk3~%NJseeTpgE_uXxYQ6?cE#b6!yA@rw^<PgKl$
zRT!}D<N4GW<B!T~lXF53ZSv6T6D>X_w&>cX;w#nZPftr4U8}bGqb^ju>sn{cw3xdJ
z3#YV(iOfqYU22}Lcstjxf2G32ox4llc)CB6U1`?1=iH~ts-0%MuB;xnoY|ACZ|!Wm
zsq6Qn!&i5HW#P}X^sSMn6|NuOeR;(J?+vc;_C8nHc1Vg|zT8<8Ic395-?vdR4;-#Y
zoA%dF<2+dM<@?{m^S2mP9$wTUHG9>64dF~>BcD*#Zkr$$K4ae#XPZy|@===>o%q&K
aYVH=%kE>5OrD<ix?G4|uYi@hogM9!#h1pI3

literal 0
HcmV?d00001

diff --git a/test/app-test-definitions.js b/test/app-test-definitions.js
index 597d78c..5dcc6e8 100644
--- a/test/app-test-definitions.js
+++ b/test/app-test-definitions.js
@@ -1,12 +1,15 @@
 const hooks = {
   onBeforeEachTest: function(done) {
     cordova.plugin.http.clearCookies();
-    cordova.plugin.http.acceptAllCerts(false, done, done);
+    cordova.plugin.http.acceptAllCerts(false, function() {
+      cordova.plugin.http.enableSSLPinning(false, done, done);
+    }, done);
   }
 };
 
 const helpers = {
   acceptAllCerts: function(done) { cordova.plugin.http.acceptAllCerts(true, done, done); },
+  enableSSLPinning: function(done) { cordova.plugin.http.enableSSLPinning(true, done, done); },
   setJsonSerializer: function(done) { done(cordova.plugin.http.setDataSerializer('json')); },
   setUtf8StringSerializer: function(done) { done(cordova.plugin.http.setDataSerializer('utf8')); },
   setUrlEncodedSerializer: function(done) { done(cordova.plugin.http.setDataSerializer('urlencoded')); },
@@ -424,6 +427,25 @@ const tests = [
       result.type.should.be.equal('resolved');
       result.data.data.should.be.equal('');
     }
+  },{
+    description: 'should pin SSL cert correctly (GET)',
+    expected: 'resolved: {"status": 200 ...',
+    before: helpers.enableSSLPinning,
+    func: function(resolve, reject) {
+      cordova.plugin.http.get('https://httpbin.org', {}, {}, resolve, reject);
+    },
+    validationFunc: function(driver, result) {
+      result.type.should.be.equal('resolved');
+    }
+  },{
+    description: 'should send deeply structured JSON object correctly (POST) #65',
+    expected: 'resolved: {"status": 200, "data": "{\\"data\\": \\"{\\\\"outerObj\\\\":{\\\\"innerStr\\\\":\\\\"testString\\\\",\\\\"innerArr\\\\":[1,2,3]}}\\" ...',
+    before: helpers.setJsonSerializer,
+    func: function(resolve, reject) { cordova.plugin.http.post('http://httpbin.org/anything', { outerObj: { innerStr: 'testString', innerArr: [1, 2, 3] }}, {}, resolve, reject); },
+    validationFunc: function(driver, result) {
+      result.type.should.be.equal('resolved');
+      JSON.parse(result.data.data).json.should.eql({ outerObj: { innerStr: 'testString', innerArr: [1, 2, 3] }});
+    }
   }
 ];