From bbd4cf01abae0e7e0d8185d532b734039d86721d Mon Sep 17 00:00:00 2001
From: Sefa Ilkimen <silkimen@users.noreply.github.com>
Date: Thu, 15 Jul 2021 12:53:12 +0200
Subject: [PATCH] refactor: apply review feddback

---
 plugin.xml                                                  | 2 +-
 src/android/com/silkimen/cordovahttp/CordovaHttpPlugin.java | 4 ++--
 test/e2e-app-template/config.xml                            | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/plugin.xml b/plugin.xml
index c25c685..776ce44 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -8,7 +8,7 @@
     <engine name="cordova" version=">=4.0.0"/>
   </engines>
   <dependency id="cordova-plugin-file" version=">=2.0.0"/>
-  <preference name="AndroidBlacklistTlsProtocols" default="SSLv3,TLSv1"/>
+  <preference name="AndroidBlacklistSecureSocketProtocols" default="SSLv3,TLSv1"/>
   <js-module src="www/cookie-handler.js" name="cookie-handler"/>
   <js-module src="www/dependency-validator.js" name="dependency-validator"/>
   <js-module src="www/error-codes.js" name="error-codes"/>
diff --git a/src/android/com/silkimen/cordovahttp/CordovaHttpPlugin.java b/src/android/com/silkimen/cordovahttp/CordovaHttpPlugin.java
index ce0c40c..becee4b 100644
--- a/src/android/com/silkimen/cordovahttp/CordovaHttpPlugin.java
+++ b/src/android/com/silkimen/cordovahttp/CordovaHttpPlugin.java
@@ -48,9 +48,9 @@ public class CordovaHttpPlugin extends CordovaPlugin implements Observer {
       this.tlsConfiguration.setHostnameVerifier(null);
       this.tlsConfiguration.setTrustManagers(tmf.getTrustManagers());
 
-      if (this.preferences.contains("androidblacklisttlsprotocols")) {
+      if (this.preferences.contains("androidblacklistsecuresocketprotocols")) {
         this.tlsConfiguration.setBlacklistedProtocols(
-          this.preferences.getString("androidblacklisttlsprotocols", "").split(",")
+          this.preferences.getString("androidblacklistsecuresocketprotocols", "").split(",")
         );
       }
 
diff --git a/test/e2e-app-template/config.xml b/test/e2e-app-template/config.xml
index ae69196..f6c6da6 100644
--- a/test/e2e-app-template/config.xml
+++ b/test/e2e-app-template/config.xml
@@ -27,5 +27,5 @@
         <allow-intent href="itms-apps:*" />
     </platform>
     <preference name="AndroidPersistentFileLocation" value="Internal" />
-    <preference name="AndroidBlacklistTlsProtocols" value="SSLv3,TLSv1" />
+    <preference name="AndroidBlacklistSecureSocketProtocols" value="SSLv3,TLSv1" />
 </widget>