refactor(eslint): use cordova-eslint /w fix (#66)

This commit is contained in:
Tim Brust
2020-07-02 10:12:53 +00:00
committed by GitHub
parent 4b719848a6
commit 57df0189e0
5 changed files with 126 additions and 108 deletions
+30 -40
View File
@@ -18,47 +18,44 @@
* under the License.
*
*/
/* jshint jasmine: true */
exports.defineAutoTests = function() {
describe('window.screen', function() {
it('should be defined', function() {
exports.defineAutoTests = function () {
describe('window.screen', function () {
it('should be defined', function () {
expect(window.screen).toBeDefined();
});
});
describe('window.screen.orientation', function() {
it('should be defined', function() {
describe('window.screen.orientation', function () {
it('should be defined', function () {
expect(window.screen.orientation).toBeDefined();
});
it('should have a `lock` function', function() {
it('should have a `lock` function', function () {
expect(window.screen.orientation.lock).toBeDefined();
expect(typeof window.screen.orientation.lock).toBe('function');
});
it('should have an `unlock` function', function() {
it('should have an `unlock` function', function () {
expect(window.screen.orientation.unlock).toBeDefined();
expect(typeof window.screen.orientation.unlock).toBe('function');
});
it('should have a `type` property (string)', function() {
it('should have a `type` property (string)', function () {
expect(window.screen.orientation.type).toBeDefined();
expect(typeof window.screen.orientation.type).toBe('string');
});
it('should have an `angle` property (number)', function() {
it('should have an `angle` property (number)', function () {
expect(window.screen.orientation.angle).toBeDefined();
expect(typeof window.screen.orientation.angle).toBe('number');
});
it('should have an `onchange` settable function', function() {
it('should have an `onchange` settable function', function () {
// it should be null to start
expect(window.screen.orientation.onchange).toBe(null);
// then we set it
var funk = function(){};
var funk = function () {};
window.screen.orientation.onchange = funk;
// now it should exist
expect(window.screen.orientation.onchange).toBeDefined();
@@ -69,24 +66,21 @@ exports.defineAutoTests = function() {
expect(window.screen.orientation.onchange).toBe(null);
});
it('should have an eventListener interface',function() {
it('should have an eventListener interface', function () {
expect(window.screen.orientation.addEventListener).toBeDefined();
expect(typeof window.screen.orientation.addEventListener).toBe('function');
expect(window.screen.orientation.removeEventListener).toBeDefined();
expect(typeof window.screen.orientation.removeEventListener).toBe('function');
});
});
describe('OrientationType', function() {
it("should be defined", function() {
describe('OrientationType', function () {
it('should be defined', function () {
expect(window.OrientationType).toBeDefined();
});
it("should have defined types", function() {
it('should have defined types', function () {
expect(window.OrientationType['portrait-primary']).toBeDefined();
expect(window.OrientationType['portrait-secondary']).toBeDefined();
expect(window.OrientationType['landscape-primary']).toBeDefined();
@@ -94,53 +88,49 @@ exports.defineAutoTests = function() {
});
});
describe('OrientationLockType', function() {
it("should be defined", function() {
describe('OrientationLockType', function () {
it('should be defined', function () {
expect(window.OrientationLockType).toBeDefined();
});
it("should have defined types", function() {
it('should have defined types', function () {
expect(window.OrientationLockType['portrait-primary']).toBeDefined();
expect(window.OrientationLockType['portrait-secondary']).toBeDefined();
expect(window.OrientationLockType['landscape-primary']).toBeDefined();
expect(window.OrientationLockType['landscape-secondary']).toBeDefined();
expect(window.OrientationLockType['portrait']).toBeDefined();
expect(window.OrientationLockType['landscape']).toBeDefined();
expect(window.OrientationLockType['any']).toBeDefined();
expect(window.OrientationLockType.portrait).toBeDefined();
expect(window.OrientationLockType.landscape).toBeDefined();
expect(window.OrientationLockType.any).toBeDefined();
});
});
// TODO:
// test addEventListener('change') works
// test onchange works
describe('window.screen.orientation', function() {
it('should successfully lock and unlock screen orientation', function() {
return window.screen.orientation.lock('portrait').then(function() {
describe('window.screen.orientation', function () {
it('should successfully lock and unlock screen orientation', function () {
return window.screen.orientation.lock('portrait').then(function () {
expect(window.screen.orientation.type).toMatch(/^portrait-/);
expect(window.screen.orientation.unlock).not.toThrow();
});
});
});
};
exports.defineManualTests = function(contentEl, createActionButton) {
createActionButton('Listen to orientationchange events', function() {
window.addEventListener("orientationchange", function(){
exports.defineManualTests = function (contentEl, createActionButton) {
createActionButton('Listen to orientationchange events', function () {
window.addEventListener('orientationchange', function () {
contentEl.innerHTML += '<p>Orientation changed! ' + screen.orientation.type + '</p>';
});
});
createActionButton('Unlock orientation', function() {
createActionButton('Unlock orientation', function () {
screen.orientation.unlock();
contentEl.innerHTML += '<p>Orientation unlocked.</p>';
});
createActionButton('Lock to portrait', function() {
createActionButton('Lock to portrait', function () {
screen.orientation.lock('portrait');
contentEl.innerHTML += '<p>Orientation locked to portrait.</p>';
});
createActionButton('Lock to landscape', function() {
createActionButton('Lock to landscape', function () {
screen.orientation.lock('landscape');
contentEl.innerHTML += '<p>Orientation locked to landscape.</p>';
});