From d2c7a2fda79a51746c4c6ab08cd19db43ea15c9e Mon Sep 17 00:00:00 2001 From: Francisco Hodge Date: Thu, 14 Apr 2022 22:37:03 -0700 Subject: [PATCH] Set PhysicalKeyboardHighlight pointerup appropriately. Per #1506 --- src/lib/services/PhysicalKeyboard.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lib/services/PhysicalKeyboard.ts b/src/lib/services/PhysicalKeyboard.ts index 1db86788..1b2e6a4e 100644 --- a/src/lib/services/PhysicalKeyboard.ts +++ b/src/lib/services/PhysicalKeyboard.ts @@ -55,7 +55,6 @@ class PhysicalKeyboard { if (options.physicalKeyboardHighlightPress) { if (options.physicalKeyboardHighlightPressUsePointerEvents) { buttonDOM.onpointerdown(); - buttonDOM.onpointerup(); } else if (options.physicalKeyboardHighlightPressUseClick) { buttonDOM.click(); } else { @@ -67,6 +66,7 @@ class PhysicalKeyboard { } handleHighlightKeyUp(event: KeyboardEvent) { + const options = this.getOptions(); const buttonPressed = this.getSimpleKeyboardLayoutKey(event); this.dispatch((instance: any) => { @@ -76,6 +76,9 @@ class PhysicalKeyboard { if (buttonDOM && buttonDOM.removeAttribute) { buttonDOM.removeAttribute("style"); + if (options.physicalKeyboardHighlightPressUsePointerEvents) { + buttonDOM.onpointerup(); + } } }); }