Sergey Abramchuk 82fea30fcc Squashed 'OpenVPN Adapter/Vendors/openvpn/' changes from 4095565..3e002c8
3e002c8 remove unused Jenkinsfile
16b1055 [OVPN3-140] Update company names in copyrights
6caca2c [OVPN3-140] Relicense back to AGPLv3
4f9ae74 cliproto: react to tls_warnings
546547b Proto: export tls_warnings attribute from SSL session
7cbaa26 SSLAPI: add tls_warning attribute
7ed93a3 clievent: add Warn event class
7a71ba1 win: get 'arch' param value from environment
61bb21b win: make parameter optional
15d66c4 [OVPN3-141] win: disable WPO
97d9c28 [OU-15] mbedtls: remove duplicated code
95aec32 [OU-15] mbedtls: refactor X509Cert to allow reuse der2pem
946753e [OVPN3-135] Win: remove unneeded default route
d7f8c47 nrpt: create separate policy per dns suffix
577b5ca cli.cpp: fix typ0 in define
fc8f89d [OVPN3-129] android: ensure all SWIG files are archived and saved
e143bc0 [OVPN3-129] android: improve build system in order to perform full build
06d23ec [OVPN3-129] build-system: let scripts download dependencies
76bb99c fix usage of to_string() in Android
44c183a time: mute type conversion warnings for UWP client
7d7490c transport: enable socket protect call for UWP
1c003ac transport: pass protocol type to external factory
c0de92c transport: add stop_requeueing method
e2c60c8 android: build core library with MD5 support
3928069 [OVPN3-119] mbedTLS: create INSECURE profile including MD5
4f99310 remove function accidentally duplicated by last merge
b91d841 self-test: add missing includes
19e33c4 [OA-14] mbedTLS: relax x509 date/time format check
f3cf645 [OVPN3-116] disable SSL_CBC_RECORD_SPLITTING
fca9ed2 [OVPN3-105] ParseClientConfig: avoid crash when not all key material is provided
7299fef [OC-42] Android: specify API level on command line
d3da3df android: build client lib for x86 (for emulator)
8e501c5 Update version for mbedTLS and lz4
e57676e ParseClientConfig: export config to json format
9aa715f ParseClientConfig: export configuration to ovpn file format
1eab4cb ParseClientConfig: add helper constructor
71a59e4 ParseClientConfig: store the entire ovpn profile
e0bb85a Transport: convert from transport protocol to config string
2fe56c3 Compress: convert from ctx type to config string
174ee25 OpenSSL: implement stub methods for new private_key_type/length() SSLAPIs
3d57708 mbedTLS: implement private_key_type/length() API
a3210f0 SSLAPI: add private_key_type/length() getter methods
8ffe888 OpenSSL: implement stub methods for new extract_* SSLAPIs
16e9160 mbedTLS: implement extended API for key material extraction
fe3d519 SSLAPI: extend API with methods to extract key material
2b4c850 Debugging: added header and build flag for valgrind run-time extensions.
b948cde ManClientInstance::Factory: added virtual stop() method.
121e975 client API: added portOverride
106981c JSON: allow alternative JSON library implementations
f206ae2 logging: added logdatetime.hpp which prepends date/time to log lines
49e933d Time: added to_double, delta_float, and delta_str methods
569b1da daemon.hpp: added class WritePid for managing pid files
63e9e04 ClientProto: reset CoarseTime object when AsioTimer is canceled
f64b501 Cleanup: allow functor to be passed by value.
ebe2560 RunContext: add configurable exit via EXIT_IN env var for debugging
1fbff4f tls-crypt: revised server-side validate_initial_packet() methods to use a BufferAllocated rather than a Buffer.
0090c51 SSLConst: added new ssl_flags() method which filters out non-ssl flags from given argument.
8379b0a CryptoDCInstance: added new RekeyType PRIMARY_SECONDARY_SWAP and use it in ProtoContext::promote_secondary_to_primary() since it more accurately reflects the underlying implementation.
18f45c2 ManClientInstance::Send: added AuthStatus::Type parameter to disconnect_user() method.
4bba803 Listen::List: added expand_ports() method.
5122e7d Listen::List: in port_offset(), set n_threads to 0 since number-of-threads data for port_offset items isn't really relevant.
4e11a6c StaticKey: added render_to_base64() and init_from_rng() methods.
190ece9 CryptoAlgs: added mode() method.
76e65cf CryptoAlgs: added AEAD_NONCE_TAIL_SIZE constant (set to 8 bytes) to represent the size in bytes of AEAD "nonce tail" normally taken from the HMAC key material.
2738718 compress: added method_to_string() method, i.e. the inverse of parse_method().
7b47f99 compress: since parse_method() performs a linear search on method, reorder so that more frequently used methods appear at the top of the list.
b428f74 library: added integer is_pow2() and log2() methods based on efficient __builtin_ffs and __builtin_clz intrinsics.
4926011 Android: adapt toolchain scripts to new SDK and move to API 26
ad4e995 mbedTLS: use mbedtls API to initialize cert object
908c611 transport: use socket_protect to communicate socket handle on UWP
92a6216 build win: read certain params from env
8166ea8 common: define uwp platform macro
0186bf6 common: report platform name as "uwp"
3f291b0 netconf: disable getting hwaddr for UWP
6365d26 transport: external factory
2ffa0c9 transport: synchronous DNS lookup
2c09c7c cliconnect.hpp: support for AsioWork always on
4f5a04d rand.hpp: allow external entropy source
b19c5da time.hpp: use GetTickCount64 on Vista and newer
712ccfc android: export DEP_DIR via vars files only if not already defined
1b5a784 asio: make sure to switch to DEP_DIR before building
4302651 changes to support android building
6f56b2b Merge pull request #21 from OpenVPN/make_test_proto_deterministic
3a5ef2b travis-ci: make testing binary deterministic
b76882d mbedtls: fix typ0 in exception message
40065a6 avoid "uninitialized variable warning"
f33e7c2 [OVPN3-5] tls-crypt: add tls-crypt support in proto.hpp test unit
74c5f4f [OVPN3-5] tls-crypt: introduce tls-crypt support
389353c proto.cpp: uninit process at the end of the execution
56a831f [OVPN3-5] crypto/ssl: add support for AES-256-CTR
7cbf539 [OVPN3-5] build script: allow user to specify its own mbedTLS folder and LDFLAGS
8ae2a3f Integrate Google Test framework
68ae101 Add swig build to jenkins pipeline
d496311 ovpncli.hpp: inline LogInfo constructor for clarity
96e0d89 Revert "Merged in OVPN3-21-prepend-log-record-with-unique- (pull request #7)"
7db95cc Make build fail on compilation errors
860129a TunBuilderCapture: make (to|from)_json methods public
2486494 random: added helper class Rand2 containing a crypto and non-crypto RNG
04175c2 appversion.hpp: Stringize VERSION -> MY_VERSION
81cb887 build script: added DPROF=1 flag
a3dd47f timestr.hpp: moved milliseconds_since_epoch() to time/epoch.hpp
59b9492 sslchoose.hpp: added SSL_LIB_NAME
8fcb797 ProtoContext::KeyContext::raw_recv() : fix state transition
e49e993 ProtoContext: comment edit
1d941aa VPNServerNetblock::Netblock refactor
7190495 Server-side renamings to break up long class names using namespaces.
3f74ec1 Listen::List: minor changes
79c789b RandomAPI: comment edit
5b5af36 Added SSLConst::SERVER_TO_SERVER flag
fe00df4 OpenSSLContext::Config::set_rng: call assert_crypto()
3ae0076 In sslchoose.hpp, move OPENVPN_LOG_SSL macro to new file ssllog.hpp
1502cf6 URL::Parse: made is_valid_uri_char() standalone and moved to validate_uri.hpp
2dcb189 Added HTTP::Status::SwitchingProtocols constant
2f57024 HTTP::HeaderList: added get_value_trim_lower() method
bee94d2 HTTP::HeaderList: get_value() and get_value_trim() should return std::string instead of const std::string
5debab1 Frame::Context: #define OPENVPN_NO_IO to allow building without i/o layer
faf8f8f StaticKey: added parse_from_base64() method
d11f250 HashString: added final_base64() method
c373bf8 CompressContext: use C++11 member initialization and remove explicit attribute on constructor
bd75cd7 RCPtr: added operator==() and operator!=() methods
7be33c5 PThreadBarrier: fixed incorrect comment
6f5f77b Link: use move semantics
17a5d89 inotify.hpp: no longer used
8ce39fc added render_hex() and render_hex_sep() methods that accept void* data
ddc8e8a Function: use std::forward
76ee587 write_binary_atomic(): added tmpdir (temporary directory) parameter
f366d55 base64: encode() now accepts void* data
462fe90 BufferType: added read(), write(), and prepend() variants that accept void* data
9ad1be4 IP::RouteType: added host_bits() method
3ebc8c7 IPv[46]::Addr::to_sockaddr() now accepts optional port number
ce0977b Support Cityhash.
fdbb0b9 IP::Addr: added validate_prefix_len()
25146d8 IP::Addr::from_ipv[4|6](): use move semantics
a264f99 Merge pull request #20 from OpenVPN/fix_travis_ci_coverity
966e212 travis: don't mess up the SSL libs for wget/curl
2b8f09d Merge pull request #19 from OpenVPN/antonio/travis-ci-to-coverity
127cbb0 travis.yml: send build to Coverity SCAN when building master
2bca49b Merge pull request #15 from OpenVPN/antonio/travis-ci
a5ce566 add basic support for Travis CI
f9b14e9 macOS: add basic logging support
2b9188d Remotelist: pass meaningful port value to resolve::async_resolve()
4ebdbd0 Merged in OVPN3-38-improve-jenkins-pipeline-script (pull request #8)
832cf7f Report build status to Bitbucket
62423c9 Merged in OVPN3-21-prepend-log-record-with-unique- (pull request #7)
cce2455 Prepend log string with unique reference.
f26b08b Merged in OVPN3-25-pipeline-build (pull request #4)
dc5ff1f Add OpenSSL version building.
c77e1d6 Add pipeline script for multiplatform build.
4fab9b0 Merged in OVPN3-18-vs-project (pull request #2)
8eb0d6c Add Visual Studio project info to README
67c4989 Visual Studio 2015 solution and project files
52bfcd3 Merged in OVPN3-17 (pull request #1)
5f648ce Document Windows build process
3213c48 Support for local build settings
b3ec01b Support for gpl version of mbedtls
903abc8 Support for zipballs
4029579 AsioPolySock: support bind to local address.
1e85566 Use openvpn::strerror_str() instead of std::strerror().
3ba37fc OpenVPN 3 client: added OPENVPN_OVPNCLI_ASYNC_SETUP flag.

git-subtree-dir: OpenVPN Adapter/Vendors/openvpn
git-subtree-split: 3e002c83ce2e9f9f40ddcee750d3cfa664238abe
2018-01-08 11:44:56 +03:00

OpenVPN 3
=========

OpenVPN 3 is a C++ class library that implements the functionality
of an OpenVPN client, and is protocol-compatible with the OpenVPN
2.x branch.

OpenVPN 3 includes a minimal client wrapper (``cli``) that links in with
the library and provides basic command line functionality.

OpenVPN 3 is currently used in production as the core of the
OpenVPN Connect clients for iOS, Android, Linux, Windows, and Mac OS X.

NOTE: As of 2017, OpenVPN 3 is primarily of interest to developers,
as it does not yet replicate the full functionality of OpenVPN 2.x.
In particular, server functionality is not yet implemented.

.. contents:: Table of Contents

OpenVPN 3 Client API
--------------------

OpenVPN 3 is organized as a C++ class library, and the API is defined in
`<client/ovpncli.hpp>`_.

A simple command-line wrapper for the API is provided in
`<test/ovpncli/cli.cpp>`_.

Building the OpenVPN 3 client on Linux
--------------------------------------

These instructions were tested on Ubuntu 16.

Get prerequisites to allow for either mbedTLS or OpenSSL linkage::

  $ sudo apt-get install g++ make libmbedtls-dev libssl-dev liblz4-dev

Get Asio C++ library::

  $ cd ~
  $ git clone https://github.com/chriskohlhoff/asio.git

Set environmental variable used by OpenVPN 3 build scripts::

  $ export O3=~/ovpn3

Clone the OpenVPN 3 source repo::

  $ mkdir ~/ovpn3
  $ cd ~/ovpn3
  $ git clone https://github.com/OpenVPN/openvpn3.git core

Build the OpenVPN 3 client wrapper (cli) with mbedTLS crypto/ssl library
and LZ4 compression::

  $ cd $O3/core/test/ovpncli
  $ ECHO=1 PROF=linux ASIO_DIR=~/asio MTLS_SYS=1 LZ4_SYS=1 NOSSL=1 $O3/core/scripts/build cli

Or alternatively build with OpenSSL::

  $ cd $O3/core/test/ovpncli
  $ ECHO=1 PROF=linux ASIO_DIR=~/asio OPENSSL_SYS=1 LZ4_SYS=1 $O3/core/scripts/build cli

Run OpenVPN 3 client::

  $ sudo ./cli -a -c yes myprofile.ovpn route-nopull

Options used::

  -a             : use autologin sessions, if supported
  -c yes         : negotiate LZ4 compression
  myprofile.ovpn : OpenVPN config file (must have .ovpn extension)
  route-nopull   : if you are connected via ssh, prevent ssh session lockout


Building the OpenVPN 3 client on Mac OS X
-----------------------------------------

OpenVPN 3 should be built in a non-root Mac OS X account.
Make sure that Xcode is installed with optional command-line tools.
(These instructions have been tested with Xcode 5.1.1).

Create the directories ``~/src`` and ``~/src/mac``::

    $ mkdir -p ~/src/mac

Clone the OpenVPN 3 repo::

    $ cd ~/src
    $ mkdir ovpn3
    $ cd ovpn3
    $ git clone https://github.com/OpenVPN/openvpn3.git core

Export the shell variable ``O3`` to point to the OpenVPN 3 top level
directory::

    export O3=~/src/ovpn3

Download source tarballs (``.tar.gz`` or ``.tgz``) for these dependency
libraries into ``~/Downloads``

See the file ``$O3/core/deps/lib-versions`` for the expected
version numbers of each dependency.  If you want to use a different
version of the library than listed here, you can edit this file.

1. Asio — https://github.com/chriskohlhoff/asio
2. mbed TLS (2.3.0 or higher) — https://tls.mbed.org/
3. LZ4 — https://github.com/Cyan4973/lz4

For dependencies that are typically cloned from github vs.
provided as a .tar.gz file, tools are provided to convert
the github to a .tar.gz file.  See "snapshot" scripts under
``$O3/core/deps``

Note that while OpenSSL is listed in lib-versions, it is
not required for Mac builds.

Build the dependencies::

    $ OSX_ONLY=1 $O3/core/scripts/mac/build-all

Now build the OpenVPN 3 client executable::

    $ cd $O3/core
    $ . vars/vars-osx64
    $ . vars/setpath
    $ cd test/ovpncli
    $ MTLS=1 LZ4=1 build cli

This will build the OpenVPN 3 client library with a small client
wrapper (``cli``).  It will also statically link in all external
dependencies (Asio, mbedTLS, and LZ4), so ``cli`` may be distributed
to other Macs and will run as a standalone executable.

These build scripts will create a **x86_x64** Mac OS X executable,
with a minimum deployment target of 10.8.x.  The Mac OS X tuntap driver is not
required, as OpenVPN 3 can use the integrated utun interface if
available.

To view the client wrapper options::

    $ ./cli -h

To connect::

    $ ./cli client.ovpn


Building the OpenVPN 3 client on Windows
----------------------------------------

Those instructions were tested with Git Bash.

Prerequisites:

 - Visual Studio 2015
 - Python 2.7

To make python interpreter work inside Git Bash terminal, add::

    alias python='winpty python.exe'

to ``.bashrc``.

Clone the OpenVPN 3 source repo::

  $ mkdir ovpn3
  $ cd ovpn3
  $ git clone https://github.com/OpenVPN/openvpn3.git core

Create ``parms_local.py`` inside ``~/ovpn3/core/win`` directory which overrides build settings from ``parms.py``. For example:

.. code-block:: python

  PARMS = {
      "OVPN3" : "c:\\Users\\user\\Projects\\ovpn3",
      "TAP" : "c:\\Users\\user\\Projects\\tap-windows",
      "DEP" : "c:\\Users\\user\\Downloads",
      "BUILD" : "c:\\Users\\user\\Projects\\ovpn3-build",
      "LIB_VERSIONS" : {
          "asio" : "asio-cc1bd58f9ebb15afbebf53207015ff690b338195"
      },
      "GTEST_ROOT": "c:\\Users\\user\\Projects\\googletest"
  }

Download dependencies as tar(zip)balls to DEP directory defined in previous step:

1. Asio — https://github.com/chriskohlhoff/asio
2. mbed TLS (2.3.0 or higher) — https://tls.mbed.org/
3. LZ4 — https://github.com/Cyan4973/lz4

Extract and build dependencies (assuming you are in ``~/ovpn3/core/win`` directory)::

    $ python buildep.py

Build the OpenVPN 3 client executable:

    $ python build.py

Visual Studio 2015 project and solution files are located in ``~/ovpn3/core/win`` directory.
Before opening project you need to build dependencies and define environmental variables:

- OVPN3_BUILD - path where dependencies are build (BUILD in parms.py)
- OVPN3_CORE - path where ovpn3-core was checked out (OVPN3 in parms.py)
- OVPN3_TAP_WINDOWS - path where tap-windows was checked out (TAP in parms.py)

Testing
-------

The OpenVPN 3 core includes a stress/performance test of
the OpenVPN protocol implementation.  The test basically
creates a virtualized lossy network between two OpenVPN
protocol objects, triggers TLS negotiations between them,
passes control/data channel messages, and measures the ability
of the OpenVPN protocol objects to perform and remain in
a valid state.

The OpenVPN protocol implementation that is being tested
is here: `<openvpn/ssl/proto.hpp>`_

The test code itself is here: `<test/ssl/proto.cpp>`_

Build the test::

  $ cd ovpn3/core/test/ssl
  $ ECHO=1 PROF=linux ASIO_DIR=~/asio MTLS_SYS=1 NOSSL=1 $O3/core/scripts/build proto

Run the test::

  $ time ./proto
  *** app bytes=72777936 net_bytes=122972447 data_bytes=415892854 prog=0000216599/0000216598 D=12700/600/12700/600 N=109/109 SH=17400/15300 HE=0/0

  real	0m15.813s
  user	0m15.800s
  sys	0m0.004s

The OpenVPN 3 core also includes unit tests, which are based on
Google Test framework. To run unit tests, you need to install
CMake and build Google Test.

Building Google Test on Linux::

  $ git clone https://github.com/google/googletest.git
  $ cd googletest
  $ cmake . && cmake --build .

Building Google Test on Windows::

  > git clone https://github.com/google/googletest.git
  > cd googletest
  > cmake -G "Visual Studio 14 2015 Win64" .
  > cmake --build .

After Google Test is built you are ready to build and run unit tests.

Build and run tests on Linux::

  $ cd ovpn3/core/test/unittests
  $ GTEST_DIR=~/googletest ECHO=1 PROF=linux ASIO_DIR=~/asio MTLS_SYS=1 LZ4_SYS=1 NOSSL=1 $O3/core/scripts/build test_log
  $ ./test_log

Build and run tests on Windows::

  $ cd ovpn3/core/win
  $ python build.py ../test/unittests/test_log.cpp unittest
  $ test_log.exe

Developer Guide
---------------

OpenVPN 3 is written in C++11 and developers who are moving
from C to C++ should take some time to familiarize themselves with
key C++ design patterns such as *RAII*:

https://en.wikipedia.org/wiki/Resource_acquisition_is_initialization

OpenVPN 3 Client Core
+++++++++++++++++++++

OpenVPN 3 is designed as a class library, with an API that
is essentially defined inside of namespace ``ClientAPI``
with headers and implementation in `<client>`_ and
header-only library files under `<openvpn>`_.

The consise definition of the client API is essentially ``class OpenVPNClient``
in `<client/ovpncli.hpp>`_ with several imporant extensions to
the API found in:

* **class TunBuilderBase** in `<openvpn/tun/builder/base.hpp>`_ —
  Provides an abstraction layer defining the *tun* interface,
  and is especially useful for interfacing with an OS-layer VPN API.

* **class ExternalPKIBase** in `<openvpn/pki/epkibase.hpp>`_ —
  Provides a callback for external private key operations, and
  is useful for interfacing with an OS-layer Keychain such as
  the Keychain on iOS, Mac OS X, and Android, and the Crypto API
  on Windows.

* **class LogReceiver** in `<client/ovpncli.hpp>`_ —
  Provides an abstraction layer for the delivery of logging messages.

OpenVPN 3 includes a command-line reference client (``cli``) for
testing the API.  See `<test/ovpncli/cli.cpp>`_.

The basic approach to building an OpenVPN 3 client is
to define a client class that derives from
``ClientAPI::OpenVPNClient``, then provide implementations
for callbacks including event and logging notifications:

.. code:: c++

  class Client : public ClientAPI::OpenVPNClient
  {
  public:
        virtual void event(const Event&) override {  // events delivered here
          ...
        }
        virtual void log(const LogInfo&) override {  // logging delivered here
          ...
        }

        ...
  };

To start the client, first create a ``ClientAPI::Config`` object
and initialize it with the OpenVPN config file and other options:

.. code:: c++

  ClientAPI::Config config;
  config.content = <config_file_content_as_multiline_string>;
  ...

Next, create a client object and evaluate the configuration:

.. code:: c++

  Client client;
  ClientAPI::EvalConfig eval = client.eval_config(config);
  if (eval.error)
    throw ...;

Finally, in a new worker thread, start the connection:

.. code:: c++

  ClientAPI::Status connect_status = client.connect();

Note that ``client.connect()`` will not return until
the session has terminated.

Top Layer
.........

The top layer of the OpenVPN 3 client is implemented
in `<test/ovpncli/cli.cpp>`_ and `<openvpn/client/cliopt.hpp>`_.
Most of what this code does is marshalling the configuration and
dispatching the higher-level objects that implement the OpenVPN
client session.

Connection
..........

``class ClientConnect`` in `<openvpn/client/cliconnect.hpp>`_
implements the top-level connection logic for an OpenVPN client
connection.  It is concerned with starting, stopping, pausing, and resuming
OpenVPN client connections.  It deals with retrying a connection and handles
the connection timeout.  It also deals with connection exceptions and understands
the difference between an exception that should halt any further reconnection
attempts (such as ``AUTH_FAILED``), and other exceptions such as network errors
that would justify a retry.

Some of the methods in the class
(such as ``stop``, ``pause``, and ``reconnect``) are often
called by another thread that is controlling the connection, therefore
thread-safe methods are provided where the thread-safe function posts a message
to the actual connection thread.

In an OpenVPN client connection, the following object stack would be used:

1. **class ClientConnect** in `<openvpn/client/cliconnect.hpp>`_ —
   The top-layer object in an OpenVPN client connection.
2. **class ClientProto::Session** in `<openvpn/client/cliproto.hpp>`_ —
   The OpenVPN client protocol object that subinstantiates the transport
   and tun layer objects.
3. **class ProtoContext** in `<openvpn/ssl/proto.hpp>`_ —
   The core OpenVPN protocol implementation that is common to both
   client and server.
4. **class ProtoStackBase<Packet>** in `<openvpn/ssl/protostack.hpp>`_ —
   The bottom-layer class that implements
   the basic functionality of tunneling a protocol over a reliable or
   unreliable transport layer, but isn't specific to OpenVPN per-se.

Transport Layer
...............

OpenVPN 3 defines abstract base classes for Transport layer
implementations in `<openvpn/transport/client/transbase.hpp>`_.

Currently, transport layer implementations are provided for:

* **UDP** — `<openvpn/transport/client/udpcli.hpp>`_
* **TCP** — `<openvpn/transport/client/tcpcli.hpp>`_
* **HTTP Proxy** — `<openvpn/transport/client/httpcli.hpp>`_

Tun Layer
.........

OpenVPN 3 defines abstract base classes for Tun layer
implementations in `<openvpn/tun/client/tunbase.hpp>`_.

There are two possible approaches to define a Tun
layer implementation:

1. Use a VPN API-centric model (such as for Android
   or iOS).  These models derive from **class TunBuilderBase**
   in `<openvpn/tun/builder/base.hpp>`_

2. Use an OS-specific model such as:

     * **Linux** — `<openvpn/tun/linux/client/tuncli.hpp>`_
     * **Windows** — `<openvpn/tun/win/client/tuncli.hpp>`_
     * **Mac OS X** — `<openvpn/tun/mac/client/tuncli.hpp>`_

Protocol Layer
..............

The OpenVPN protocol is implemented in **class ProtoContext**
in `<openvpn/ssl/proto.hpp>`_.

Options Processing
..................

The parsing and query of the OpenVPN config file
is implemented by ``class OptionList`` in
`<openvpn/common/options.hpp>`_.

Note that OpenVPN 3 always assumes an *inline* style of
configuration, where all certs, keys, etc. are
defined inline rather than through an external file
reference.

For config files that do use external file references,
``class ProfileMerge`` in `<openvpn/options/merge.hpp>`_
is provided to merge those external
file references into an inline form.

Calling the Client API from other languages
...........................................

The OpenVPN 3 client API, as defined by ``class OpenVPNClient``
in `<client/ovpncli.hpp>`_, can be wrapped by the
Swig_ tool to create bindings for other languages.

.. _Swig: http://www.swig.org/

For example, OpenVPN Connect for Android creates a Java
binding of the API using `<javacli/ovpncli.i>`_.

Security
++++++++

When developing security software in C++, it's very important to
take advantage of the language and OpenVPN library code
to insulate code from the kinds of
bugs that can introduce security vulnerabilities.

Here is a brief set of guidelines:

* When dealing with strings, use a ``std::string``
  rather than a ``char *``.

* When dealing with binary data or buffers, always try to use a ``Buffer``,
  ``ConstBuffer``, ``BufferAllocated``, or ``BufferPtr`` object to
  provide managed access to the buffer, to protect against security
  bugs that arise when using raw buffer pointers.
  See `<openvpn/buffer/buffer.hpp>`_ for the OpenVPN ``Buffer`` classes.

* When it's necessary to have a pointer to an object, use
  ``std::unique_ptr<>`` for non-shared objects and reference-counted
  smart pointers for shared objects.  For shared-pointers,
  OpenVPN code should use the smart pointer classes defined
  in `<openvpn/common/rc.hpp>`_.  Please see the comments in
  this file for documentation.

* Never use ``malloc`` or ``free``.  When allocating objects,
  use the C++ ``new`` operator and then immediately construct
  a smart pointer to reference the object:

  .. code:: c++

    std::unique_ptr<MyObject> ptr = new MyObject();
    ptr->method();

* When interfacing with C functions that deal with
  raw pointers, memory allocation, etc., consider wrapping
  the functionality in C++.  For an example, see ``enum_dir()``
  in `<openvpn/common/enumdir.hpp>`_,
  a function that returns a list of files in
  a directory (Unix only) via a high-level
  string vector, while internally calling
  the low level libc methods
  ``opendir``, ``readdir``, and ``closedir``.
  Notice how ``unique_ptr_del`` is used to wrap the
  ``DIR`` struct in a smart pointer with a custom
  deletion function.

* When grabbing random entropy that is to be used
  for cryptographic purposes (i.e. for keys, tokens, etc.),
  always ensure that the RNG is crypto-grade by calling
  ``assert_crypto()`` on the RNG.  This will throw
  an exception if the RNG is not crypto-grade:

  .. code:: c++

    void set_rng(RandomAPI::Ptr rng_arg) {
      rng_arg->assert_crypto();
      rng = std::move(rng_arg);
    }

* Any variable whose value is not expected to change should
  be declared ``const``.

* Don't use non-const global or static variables unless absolutely
  necessary.

* When formatting strings, don't use ``snprintf``.  Instead, use
  ``std::ostringstream`` or build the string using the '+' ``std::string``
  operator:

  .. code:: c++

    std::string format_reconnecting(const int n_seconds) {
      return "Reconnecting in " + openvpn::to_string(n_seconds) + " seconds.";
    }

  or:

  .. code:: c++

    std::string format_reconnecting(const int n_seconds) {
      std::ostringstream os;
      os << "Reconnecting in " << n_seconds << " seconds.";
      return os.str();
    }

* OpenVPN 3 is a "header-only" library, therefore all free functions
  outside of classes should have the ``inline`` attribute.

Conventions
+++++++++++

* Use the **Asio** library for I/O and timers.
  Don't deal with sockets directly.

* Never block.  If you need to wait for something, use **Asio** timers
  or sockets.

* Use the ``OPENVPN_LOG()`` macro to log stuff.  Don't use ``printf``.

* Don't call crypto/ssl libraries directly.  Instead use the abstraction
  layers (`<openvpn/crypto>`_ and `<openvpn/ssl>`_) that allow OpenVPN
  to link with different crypto/ssl libraries (such as **OpenSSL**
  or **mbed TLS**).

* Use ``RandomAPI`` as a wrapper for random number
  generators (`<openvpn/random/randapi.hpp>`_).

* If you need to deal with configuration file options,
  see ``class OptionList`` in `<openvpn/common/options.hpp>`_.

* If you need to deal with time or time durations, use the
  classes under `<openvpn/time>`_.

* If you need to deal with IP addresses, see the comprehensive classes
  under `<openvpn/addr>`_.

* In general, if you need a general-purpose library class or function,
  look under `<openvpn/common>`_.  Chances are good that it's already
  been implemented.

* The OpenVPN 3 approach to errors is to count them, rather than
  unconditionally log them.  If you need to add a new error
  counter, see `<openvpn/error/error.hpp>`_.

* If you need to create a new event type which can be transmitted
  as a notification back to the client API user, see
  `<openvpn/client/clievent.hpp>`_.

* Raw pointers or references can be okay when used by an object to
  point back to its parent (or container), if you can guarantee that
  the object will not outlive its parent.  Backreferences to a parent
  object is also a common use case for weak pointers.

* Use C++ exceptions for error handling and as an alternative
  to ``goto``.  See OpenVPN's general exception classes
  and macros in `<openvpn/common/exception.hpp>`_.

* Use C++ destructors for automatic object cleanup, and so
  that thrown exceptions will not leak objects.  Alternatively,
  use ``Cleanup`` in `<openvpn/common/cleanup.hpp>`_ when
  you need to specify a code block to execute prior to scope
  exit.  For example, ensure that the file ``pid_fn`` is
  deleted before scope exit:

  .. code:: c++

    auto clean = Cleanup([pid_fn]() {
      if (pid_fn)
        ::unlink(pid_fn);
    });

* When calling global methods (such as libc ``fork``),
  prepend "::" to the symbol name, e.g.:

  .. code:: c++

    struct dirent *e;
    while ((e = ::readdir(dir.get())) != nullptr) {
      ...
    }

* Use ``nullptr`` instead of ``NULL``.

Threading
+++++++++

The OpenVPN 3 client core is designed to run in a single thread, with
the UI or controller driving the OpenVPN API running in a different
thread.

It's almost never necessary to create additional threads within
the OpenVPN 3 client core.


Contributing
------------

See `<CONTRIBUTING.rst>`_.

License
-------

See `<LICENSE.rst>`_.
 
Description
No description provided
Readme AGPL-3.0 45 MiB
Languages
C++ 57.5%
C 33.3%
Shell 3.1%
Makefile 1.3%
Perl 0.9%
Other 3.7%