#71 ios toast get error while message is integer

README.md - replaced , with : for valid JSON in success callback example

README.md

@@ -2,6 +2,9 @@
 
 for Android, iOS and WP8, by [Eddy Verbruggen](http://www.x-services.nl/phonegap-toast-plugin/796)
 
+[![paypal](https://www.paypalobjects.com/en_US/i/btn/btn_donate_SM.gif)](https://www.paypal.com/cgi-bin/webscr?cmd=_donations&business=eddyverbruggen%40gmail%2ecom&lc=US&item_name=cordova%2dplugin%2dtoast&currency_code=USD&bn=PP%2dDonationsBF%3abtn_donate_SM%2egif%3aNonHosted)
+If you like this plugin and want to say thanks please send a PR or donation. Both are equally appreciated!
+
 
 <table width="100%">
     <tr>
@@ -138,7 +141,7 @@ Toast.js is brought in automatically. There is no need to change or add anything
 ### Showing a Toast
 You have two choices to make when showing a Toast: where to show it and for how long.
 * show(message, duration, position)
-* duration: 'short', 'long'
+* duration: 'short', 'long', '3000', 900 (the latter are milliseconds)
 * position: 'top', 'center', 'bottom'
 
 You can also use any of these convenience methods:
@@ -164,7 +167,7 @@ function showBottom() {
   window.plugins.toast.showWithOptions(
     {
       message: "hey there",
-      duration: "short",
+      duration: "short", // which is 2000 ms. "long" is 4000. Or specify the nr of ms yourself.
       position: "bottom",
       addPixelsY: -40  // added a negative value to move it up a bit (default 0)
     },
@@ -193,10 +196,10 @@ called again. You can distinguish between those events of course:
   window.plugins.toast.showWithOptions(
     {
       message: "hey there",
-      duration: "short",
+      duration: 1500, // ms
       position: "bottom",
       addPixelsY: -40,  // (optional) added a negative value to move it up a bit (default 0)
-      data: {'foo','bar'} // (optional) pass in a JSON object here (it will be sent back in the success callback below)
+      data: {'foo':'bar'} // (optional) pass in a JSON object here (it will be sent back in the success callback below)
     },
     // implement the success callback
     function(result) {
@@ -221,11 +224,12 @@ Note that on WP this object is currently ignored.
 ```js
   window.plugins.toast.showWithOptions({
     message: "hey there",
-    duration: "short",
+    duration: "short", // 2000 ms
     position: "bottom",
     styling: {
       opacity: 0.75, // 0.0 (transparent) to 1.0 (opaque). Default 0.8
       backgroundColor: '#FF0000', // make sure you use #RRGGBB. Default #333333
+      textColor: '#FFFF00', // Ditto. Default #FFFFFF
       cornerRadius: 16, // minimum is 0 (square). iOS default 20, Android default 100
       horizontalPadding: 20, // iOS default 16, Android default 50
       verticalPadding: 16 // iOS default 12, Android default 30
@@ -250,6 +254,9 @@ The Android code was entirely created by me.
 For iOS most credits go to this excellent [Toast for iOS project by Charles Scalesse] (https://github.com/scalessec/Toast).
 
 ## 6. CHANGELOG
+- 2.5.0: By popular demand: Specify the duration of the Toast on iOS and Android. Pass in `short` (2000ms), `long` (4000ms), or any nr of milliseconds: `900`.
+- 2.4.2: You can now also set the Toast `opacity` for iOS.
+- 2.4.1: As an addition to 2.4.0, [Sino](https://github.com/SinoBoeckmann) added the option to change the text color!
 - 2.4.0: You can now style the Toast with a number of properties. See
 - 2.3.2: The click event introduced with 2.3.0 did not work with Android 5+.
 - 2.3.0: The plugin will now report back to JS if Toasts were tapped by the user.

issue_template.md

@@ -0,0 +1,42 @@
+### Expected behaviour
+Tell us what should happen.
+
+### Actual behaviour
+Tell us what happens instead. Provide a log message if relevant.
+
+### I'm seeing this behaviour on
+_Remove this hint: these checkboxes can be checked like this: [x]_
+
+- [ ] iOS device
+- [ ] iOS sim
+- [ ] Android device
+- [ ] Android sim
+
+#### Hardware models
+Example: Samsung Galaxy S6, iPhone 6s
+
+#### OS versions
+Example: Android 4.4.2, iOS 9.2
+
+### I'm not a dummy, so I've checked these
+- [ ] It happens on a fresh Cordova CLI project as well.
+- [ ] I'm waiting for `deviceready` to fire.
+- [ ] My JavaScript has no errors (`window.onerror` catches nothing).
+
+### So how can we reproduce this?
+_Remove this hint: Pick one of these - use the Preview feature of this editor to get a sense which option we like best_
+
+#### Awesome :star::star::star::star::star:
+Provide a (link to a) minimal demo app showing the faulty behaviour.
+
+#### Sweet :star::star::star::star:
+Provide a concise code sample which can be dropped into a freshly created Cordova CLI app.
+
+#### Good :star::star::star:
+Provide your own app and instructions how to reproduce the issue.
+
+#### Meh :star::star:
+Provide a code sample with a bunch of magic parameters which I need to interpolate by guessing to reconstruct the actual runtime code.
+
+#### Worst :poop:
+Say the source code can't be disclosed and refuse to provide any of the above. Expect this issue to be closed by a bunch of angry aliens :alien::alien::alien::alien::alien: that will hunt you down and :fire: your :computer:. You've been warned. :fire_engine:

package.json

@@ -1,6 +1,6 @@
 {
   "name": "cordova-plugin-x-toast",
-  "version": "2.4.0",
+  "version": "2.5.0",
   "description": "This plugin allows you to show a Toast. A Toast is a little non intrusive buttonless popup which automatically disappears.",
   "cordova": {
     "id": "cordova-plugin-x-toast",

plugin.xml

@@ -2,7 +2,7 @@
 <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
         xmlns:android="http://schemas.android.com/apk/res/android"
         id="cordova-plugin-x-toast"
-        version="2.4.0">
+        version="2.5.0">
 
   <name>Toast</name>
 

src/android/nl/xservices/plugins/Toast.java

@@ -3,10 +3,12 @@ package nl.xservices.plugins;
 import android.graphics.Color;
 import android.graphics.drawable.GradientDrawable;
 import android.os.Build;
+import android.os.CountDownTimer;
 import android.view.Gravity;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.ViewGroup;
+import android.widget.TextView;
 
 import org.apache.cordova.CallbackContext;
 import org.apache.cordova.CordovaPlugin;
@@ -15,16 +17,6 @@ import org.json.JSONArray;
 import org.json.JSONException;
 import org.json.JSONObject;
 
-/*
-    // TODO nice way for the Toast plugin to offer a longer delay than the default short and long options
-    // TODO also look at https://github.com/JohnPersano/Supertoasts
-    new CountDownTimer(6000, 1000) {
-      public void onTick(long millisUntilFinished) {toast.show();}
-      public void onFinish() {toast.show();}
-    }.start();
-
-    Also, check https://github.com/JohnPersano/SuperToasts
- */
 public class Toast extends CordovaPlugin {
 
   private static final String ACTION_SHOW_EVENT = "show";
@@ -39,29 +31,24 @@ public class Toast extends CordovaPlugin {
   private android.widget.Toast mostRecentToast;
   private ViewGroup viewGroup;
 
-  private static final boolean IS_AT_LEAST_LOLLIPOP = Build.VERSION.SDK_INT >= 21;
-
   // note that webView.isPaused() is not Xwalk compatible, so tracking it poor-man style
   private boolean isPaused;
 
+  private static CountDownTimer _timer;
+
   @Override
   public boolean execute(String action, JSONArray args, final CallbackContext callbackContext) throws JSONException {
     if (ACTION_HIDE_EVENT.equals(action)) {
-      if (mostRecentToast != null) {
-        mostRecentToast.cancel();
-        getViewGroup().setOnTouchListener(null);
-      }
+      hide();
       callbackContext.success();
       return true;
 
     } else if (ACTION_SHOW_EVENT.equals(action)) {
-
       if (this.isPaused) {
         return true;
       }
 
       final JSONObject options = args.getJSONObject(0);
-
       final String message = options.getString("message");
       final String duration = options.getString("duration");
       final String position = options.getString("position");
@@ -71,10 +58,20 @@ public class Toast extends CordovaPlugin {
 
       cordova.getActivity().runOnUiThread(new Runnable() {
         public void run() {
+          int hideAfterMs;
+          if ("short".equalsIgnoreCase(duration)) {
+            hideAfterMs = 2000;
+          } else if ("long".equalsIgnoreCase(duration)) {
+            hideAfterMs = 4000;
+          } else {
+            // assuming a number of ms
+            hideAfterMs = Integer.parseInt(duration);
+          }
           final android.widget.Toast toast = android.widget.Toast.makeText(
-              IS_AT_LEAST_LOLLIPOP ? cordova.getActivity().getWindow().getContext() : cordova.getActivity().getApplicationContext(),
+              Build.VERSION.SDK_INT >= 21 ? cordova.getActivity().getWindow().getContext() : cordova.getActivity().getApplicationContext(),
               message,
-              "short".equals(duration) ? android.widget.Toast.LENGTH_SHORT : android.widget.Toast.LENGTH_LONG);
+              android.widget.Toast.LENGTH_LONG // actually controlled by a timer further down
+          );
 
           if ("top".equals(position)) {
             toast.setGravity(GRAVITY_TOP, 0, BASE_TOP_BOTTOM_OFFSET + addPixelsY);
@@ -92,6 +89,7 @@ public class Toast extends CordovaPlugin {
 
             // the defaults mimic the default toast as close as possible
             final String backgroundColor = styling.optString("backgroundColor", "#333333");
+            final String textColor = styling.optString("textColor", "#ffffff");
             final double opacity = styling.optDouble("opacity", 0.8);
             final int cornerRadius = styling.optInt("cornerRadius", 100);
             final int horizontalPadding = styling.optInt("horizontalPadding", 50);
@@ -102,6 +100,11 @@ public class Toast extends CordovaPlugin {
             shape.setAlpha((int)(opacity * 255)); // 0-255, where 0 is an invisible background
             shape.setColor(Color.parseColor(backgroundColor));
             toast.getView().setBackground(shape);
+
+            final TextView toastTextView;
+            toastTextView = (TextView) toast.getView().findViewById(android.R.id.message);
+            toastTextView.setTextColor(Color.parseColor(textColor));
+
             toast.getView().setPadding(horizontalPadding, verticalPadding, horizontalPadding, verticalPadding);
 
             // this gives the toast a very subtle shadow on newer devices
@@ -110,67 +113,60 @@ public class Toast extends CordovaPlugin {
             }
           }
 
-          // On Android >= 5 you can no longer rely on the 'toast.getView().setOnTouchListener',
+          // On newer Android devices you can no longer rely on the 'toast.getView().setOnTouchListener',
           // so created something funky that compares the Toast position to the tap coordinates.
-          if (IS_AT_LEAST_LOLLIPOP) {
-            getViewGroup().setOnTouchListener(new View.OnTouchListener() {
-              @Override
-              public boolean onTouch(View view, MotionEvent motionEvent) {
-                if (motionEvent.getAction() != MotionEvent.ACTION_DOWN) {
-                  return false;
-                }
-                if (mostRecentToast == null || !mostRecentToast.getView().isShown()) {
-                  getViewGroup().setOnTouchListener(null);
-                  return false;
-                }
-
-                float w = mostRecentToast.getView().getWidth();
-                float startX = (view.getWidth() / 2) - (w / 2);
-                float endX = (view.getWidth() / 2) + (w / 2);
-
-                float startY;
-                float endY;
-
-                float g = mostRecentToast.getGravity();
-                float y = mostRecentToast.getYOffset();
-                float h = mostRecentToast.getView().getHeight();
-
-                if (g == GRAVITY_BOTTOM) {
-                  startY = view.getHeight() - y - h;
-                  endY = view.getHeight() - y;
-                } else if (g == GRAVITY_CENTER) {
-                  startY = (view.getHeight() / 2) + y - (h / 2);
-                  endY = (view.getHeight() / 2) + y + (h / 2);
-                } else {
-                  // top
-                  startY = y;
-                  endY = y + h;
-                }
-
-                float tapX = motionEvent.getX();
-                float tapY = motionEvent.getY();
-
-                final boolean tapped = tapX >= startX && tapX <= endX &&
-                    tapY >= startY && tapY <= endY;
-
-                if (tapped) {
-                  getViewGroup().setOnTouchListener(null);
-                  return returnTapEvent(message, data, callbackContext);
-                }
+          getViewGroup().setOnTouchListener(new View.OnTouchListener() {
+            @Override
+            public boolean onTouch(View view, MotionEvent motionEvent) {
+              if (motionEvent.getAction() != MotionEvent.ACTION_DOWN) {
                 return false;
               }
-            });
-          } else {
-            toast.getView().setOnTouchListener(new View.OnTouchListener() {
-              @Override
-              public boolean onTouch(View view, MotionEvent motionEvent) {
-                return motionEvent.getAction() == MotionEvent.ACTION_DOWN && returnTapEvent(message, data, callbackContext);
+              if (mostRecentToast == null || !mostRecentToast.getView().isShown()) {
+                getViewGroup().setOnTouchListener(null);
+                return false;
               }
-            });
-          }
 
-          toast.show();
+              float w = mostRecentToast.getView().getWidth();
+              float startX = (view.getWidth() / 2) - (w / 2);
+              float endX = (view.getWidth() / 2) + (w / 2);
+
+              float startY;
+              float endY;
+
+              float g = mostRecentToast.getGravity();
+              float y = mostRecentToast.getYOffset();
+              float h = mostRecentToast.getView().getHeight();
+
+              if (g == GRAVITY_BOTTOM) {
+                startY = view.getHeight() - y - h;
+                endY = view.getHeight() - y;
+              } else if (g == GRAVITY_CENTER) {
+                startY = (view.getHeight() / 2) + y - (h / 2);
+                endY = (view.getHeight() / 2) + y + (h / 2);
+              } else {
+                // top
+                startY = y;
+                endY = y + h;
+              }
+
+              float tapX = motionEvent.getX();
+              float tapY = motionEvent.getY();
+
+              final boolean tapped = tapX >= startX && tapX <= endX &&
+                  tapY >= startY && tapY <= endY;
+
+              return tapped && returnTapEvent(message, data, callbackContext);
+            }
+          });
+
+          // trigger show every 2500 ms for as long as the requested duration
+          _timer = new CountDownTimer(hideAfterMs, 2500) {
+            public void onTick(long millisUntilFinished) {toast.show();}
+            public void onFinish() {toast.cancel();}
+          }.start();
+
           mostRecentToast = toast;
+          toast.show();
 
           PluginResult pr = new PluginResult(PluginResult.Status.OK);
           pr.setKeepCallback(true);
@@ -185,6 +181,16 @@ public class Toast extends CordovaPlugin {
     }
   }
 
+  private void hide() {
+    if (mostRecentToast != null) {
+      mostRecentToast.cancel();
+      getViewGroup().setOnTouchListener(null);
+    }
+    if (_timer != null) {
+      _timer.cancel();
+    }
+  }
+
   private boolean returnTapEvent(String message, JSONObject data, CallbackContext callbackContext) {
     final JSONObject json = new JSONObject();
     try {
@@ -195,6 +201,7 @@ public class Toast extends CordovaPlugin {
       e.printStackTrace();
     }
     callbackContext.success(json);
+    hide();
     return true;
   }
 
@@ -208,10 +215,7 @@ public class Toast extends CordovaPlugin {
 
   @Override
   public void onPause(boolean multitasking) {
-    if (mostRecentToast != null) {
-      mostRecentToast.cancel();
-      getViewGroup().setOnTouchListener(null);
-    }
+    hide();
     this.isPaused = true;
   }
 
@@ -219,4 +223,4 @@ public class Toast extends CordovaPlugin {
   public void onResume(boolean multitasking) {
     this.isPaused = false;
   }
-}
+}

src/ios/Toast+UIView.m

@@ -140,11 +140,14 @@ static id styling;
     UIView *v = [vc view];
     [v addSubview:toast];
 
+    NSNumber * opacity = styling[@"opacity"];
+    CGFloat theOpacity = opacity == nil ? CSToastOpacity : [opacity floatValue];
+
     [UIView animateWithDuration:CSToastFadeDuration
                           delay:0.0
                         options:(UIViewAnimationOptionCurveEaseOut | UIViewAnimationOptionAllowUserInteraction)
                      animations:^{
-                         toast.alpha = CSToastOpacity;
+                         toast.alpha = theOpacity;
                      } completion:^(BOOL finished) {
                          NSTimer *timer = [NSTimer scheduledTimerWithTimeInterval:duration target:self selector:@selector(toastTimerDidFinish:) userInfo:toast repeats:NO];
                          // associate the timer with the toast view
@@ -319,16 +322,13 @@ static id styling;
     NSString * backgroundColor = styling[@"backgroundColor"];
     UIColor *theColor = backgroundColor == nil ? [UIColor blackColor] : [self colorFromHexString:backgroundColor];
 
-    NSNumber * opacity = styling[@"opacity"];
-    CGFloat theOpacity = opacity == nil ? CSToastOpacity : [opacity floatValue];
-
     NSNumber * horizontalPadding = styling[@"horizontalPadding"];
     NSNumber * verticalPadding = styling[@"verticalPadding"];
     CGFloat theHorizontalPadding = horizontalPadding == nil ? CSToastHorizontalPadding : [horizontalPadding floatValue];
     CGFloat theVerticalPadding = verticalPadding == nil ? CSToastVerticalPadding : [verticalPadding floatValue];
     
-    wrapperView.backgroundColor = [theColor colorWithAlphaComponent:theOpacity];
-    
+    wrapperView.backgroundColor = theColor;
+
     if(image != nil) {
         imageView = [[UIImageView alloc] initWithImage:image];
         imageView.contentMode = UIViewContentModeScaleAspectFit;
@@ -347,12 +347,15 @@ static id styling;
     }
     
     if (title != nil) {
+        NSString * titleLabelTextColor = styling[@"textColor"];
+        UIColor *theTitleLabelTextColor = titleLabelTextColor == nil ? [UIColor whiteColor] : [self colorFromHexString:titleLabelTextColor];
+
         titleLabel = [[UILabel alloc] init];
         titleLabel.numberOfLines = CSToastMaxTitleLines;
         titleLabel.font = [UIFont boldSystemFontOfSize:CSToastFontSize];
         titleLabel.textAlignment = NSTextAlignmentLeft;
         titleLabel.lineBreakMode = NSLineBreakByWordWrapping;
-        titleLabel.textColor = [UIColor whiteColor];
+        titleLabel.textColor = theTitleLabelTextColor;
         titleLabel.backgroundColor = [UIColor clearColor];
         titleLabel.alpha = 1.0;
         titleLabel.text = title;
@@ -364,11 +367,14 @@ static id styling;
     }
     
     if (message != nil) {
+        NSString * messageLabelTextColor = styling[@"textColor"];
+        UIColor *theMessageLabelTextColor = messageLabelTextColor == nil ? [UIColor whiteColor] : [self colorFromHexString:messageLabelTextColor];
+
         messageLabel = [[UILabel alloc] init];
         messageLabel.numberOfLines = CSToastMaxMessageLines;
         messageLabel.font = [UIFont systemFontOfSize:CSToastFontSize];
         messageLabel.lineBreakMode = NSLineBreakByWordWrapping;
-        messageLabel.textColor = [UIColor whiteColor];
+        messageLabel.textColor = theMessageLabelTextColor;
         messageLabel.backgroundColor = [UIColor clearColor];
         messageLabel.alpha = 1.0;
         messageLabel.text = message;

src/ios/Toast.m

@@ -5,42 +5,38 @@
 @implementation Toast
 
 - (void)show:(CDVInvokedUrlCommand*)command {
-
   NSDictionary* options = [command argumentAtIndex:0];
-
   NSString *message  = options[@"message"];
   NSString *duration = options[@"duration"];
   NSString *position = options[@"position"];
   NSDictionary *data = options[@"data"];
   NSNumber *addPixelsY = options[@"addPixelsY"];
   NSDictionary *styling = options[@"styling"];
-
+  
   if (![position isEqual: @"top"] && ![position isEqual: @"center"] && ![position isEqual: @"bottom"]) {
     CDVPluginResult * pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:@"invalid position. valid options are 'top', 'center' and 'bottom'"];
     [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
     return;
   }
-
-  NSInteger durationInt;
-  if ([duration isEqual: @"short"]) {
-    durationInt = 2;
-  } else if ([duration isEqual: @"long"]) {
-    durationInt = 5;
+  
+  NSTimeInterval durationMS;
+  if ([duration.lowercaseString isEqualToString: @"short"]) {
+    durationMS = 2000;
+  } else if ([duration.lowercaseString isEqualToString: @"long"]) {
+    durationMS = 4000;
   } else {
-    CDVPluginResult * pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:@"invalid duration. valid options are 'short' and 'long'"];
-    [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
-    return;
+    durationMS = [duration intValue];
   }
-
+  
   [self.webView makeToast:message
-                 duration:durationInt
+                 duration:durationMS / 1000
                  position:position
                addPixelsY:addPixelsY == nil ? 0 : [addPixelsY intValue]
                      data:data
                   styling:styling
           commandDelegate:self.commandDelegate
                callbackId:command.callbackId];
-
+  
   CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
   pluginResult.keepCallback = [NSNumber numberWithBool:YES];
   [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
@@ -48,7 +44,7 @@
 
 - (void)hide:(CDVInvokedUrlCommand*)command {
   [self.webView hideToast];
-
+  
   CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
   [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
 }

src/wp8/Toast.cs

@@ -126,10 +126,10 @@ namespace WPCordovaClassLib.Cordova.Commands
                             return;
                         }
 
-                        int hideDelay = 2800;
+                        int hideDelay = 2500;
                         if ("long".Equals(duration))
                         {
-                            hideDelay = 5500;
+                            hideDelay = 5000;
                         }
                         else if (!"short".Equals(duration))
                         {

www/Toast.js

@@ -11,12 +11,12 @@ Toast.prototype.optionsBuilder = function () {
 
   return {
     withMessage: function(m) {
-      message = m;
+      message = m.toString();
       return this;
     },
 
     withDuration: function(d) {
-      duration = d;
+      duration = d.toString();
       return this;
     },
 
@@ -43,6 +43,8 @@ Toast.prototype.optionsBuilder = function () {
 
 
 Toast.prototype.showWithOptions = function (options, successCallback, errorCallback) {
+  options.duration = (options.duration === undefined ? 'long' : options.duration.toString());
+  options.message = options.message.toString();
   cordova.exec(successCallback, errorCallback, "Toast", "show", [options]);
 };