chore(): update changelog

CHANGELOG.md

@@ -1,3 +1,13 @@
+<a name="2.1.7"></a>
+## [2.1.7](https://github.com/driftyco/ionic-native/compare/v2.1.6...v2.1.7) (2016-10-07)
+
+
+### Bug Fixes
+
+* **paypal:** fixed currency code not found issue ([#653](https://github.com/driftyco/ionic-native/issues/653)) ([598f8a9](https://github.com/driftyco/ionic-native/commit/598f8a9))
+
+
+
 <a name="2.1.6"></a>
 ## [2.1.6](https://github.com/driftyco/ionic-native/compare/v2.1.5...v2.1.6) (2016-10-06)
 

gulpfile.js

@@ -2,7 +2,7 @@ var gulp = require('gulp');
 var minimist = require('minimist');
 var uglify = require('gulp-uglify');
 var rename = require("gulp-rename");
-var tslint = require('ionic-gulp-tslint');
+var tslint = require('gulp-tslint');
 var decamelize = require('decamelize');
 var replace = require('gulp-replace');
 
@@ -28,7 +28,12 @@ gulp.task("minify:dist", function(){
 });
 
 gulp.task('lint', function() {
-  tslint({src: 'src/**/*.ts'});
+  gulp.src('src/**/*.ts')
+    .pipe(tslint({
+      formatter: "verbose",
+      configuration: 'tslint.json'
+    }))
+    .pipe(tslint.report())
 });
 
 gulp.task('plugin:create', function(){

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ionic-native",
-  "version": "2.1.6",
+  "version": "2.1.7",
   "description": "Native plugin wrappers for Cordova and Ionic with TypeScript, ES6+, Promise and Observable support",
   "main": "dist/es5/index.js",
   "module": "dist/esm/index.js",
@@ -26,9 +26,8 @@
     "gulp": "^3.9.1",
     "gulp-rename": "^1.2.2",
     "gulp-replace": "^0.5.4",
-    "gulp-tslint": "^5.0.0",
+    "gulp-tslint": "^6.1.2",
     "gulp-uglify": "^1.5.4",
-    "ionic-gulp-tslint": "^1.0.0",
     "jasmine-core": "~2.5.0",
     "karma": "~1.2.0",
     "karma-browserify": "~5.1.0",
@@ -41,7 +40,7 @@
     "q": "1.4.1",
     "semver": "^5.0.1",
     "tsify": "~1.0.4",
-    "tslint": "^3.8.1",
+    "tslint": "^3.15.1",
     "tslint-ionic-rules": "0.0.5",
     "typescript": "^2.0.1",
     "watchify": "~3.7.0"

src/plugins/pay-pal.ts

@@ -101,13 +101,13 @@ export class PayPalPayment {
    * Convenience constructor.
    * Returns a PayPalPayment with the specified amount, currency code, and short description.
    * @param {String} amount: The amount of the payment.
-   * @param {String} currencyCode: The ISO 4217 currency for the payment.
+   * @param {String} currency: The ISO 4217 currency for the payment.
    * @param {String} shortDescription: A short description of the payment.
    * @param {String} intent: "Sale" for an immediate payment.
    */
-  constructor(amount: string, currencyCode: string, shortDescription: string, intent: string) {
+  constructor(amount: string, currency: string, shortDescription: string, intent: string) {
     this.amount = amount;
-    this.currencyCode = currencyCode;
+    this.currency = currency;
     this.shortDescription = shortDescription;
     this.intent = intent;
   }
@@ -119,7 +119,7 @@ export class PayPalPayment {
   /**
    * The ISO 4217 currency for the payment.
    */
-  currencyCode: string;
+  currency: string;
   /**
    * A short description of the payment.
    */

src/plugins/plugin.ts

@@ -77,8 +77,10 @@ function setIndex(args: any[], opts: any = {}, resolve?: Function, reject?: Func
   } else {
     // Otherwise, let's tack them on to the end of the argument list
     // which is 90% of cases
-    args.push(resolve);
-    args.push(reject);
+    if (!opts.sync) {
+      args.push(resolve);
+      args.push(reject);
+    }
   }
   return args;
 }

test/plugin.spec.ts

@@ -36,7 +36,7 @@ describe('plugin', () => {
     const spy = spyOn(window.plugins.test, 'syncMethod').and.callThrough();
     const result = Test.syncMethod('foo');
     expect(result).toEqual('syncResult');
-    expect(spy).toHaveBeenCalledWith('foo', undefined, undefined);
+    expect(spy).toHaveBeenCalledWith('foo');
 
   });
 
@@ -138,4 +138,4 @@ describe('plugin', () => {
 
   });
 
-});
+});