release v1.6.2

- updated version number

.npmignore

@@ -2,3 +2,4 @@ tags
 .zedstate
 /scripts
 /temp
+/test

.travis.yml

@@ -1,6 +1,43 @@
-language: node_js
-node_js:
-- lts/*
+sudo: false
+
+language: objective-c
+os: osx
+osx_image: xcode9.1
+
+cache: false
+
+addons:
+  sauce_connect:
+    username: silkimen
+  jwt: RZHC8x5ggrXdu1xzhhHmQDwege9s3putJXY1ZG8+MNMaBTLfLBWzFsHuR6Lvz+XnrAT/CTGG957kw6ikSaV6VEkGvtO91irZoJyShjPq2hBbn2CaEbo91Eq8iNYaRG+4FVMxoHa6xpF/HtvOLQdIkURc/lzLj/BOFMmtV/d3adLDcryQZuYB211iN4d6exGHMQe8uvJdkCy4ac85guhF8KmAELyaVa0rx0m6gNaszWU9BJ8Rn+4HJbJtfpQcU1bJN43Dx8forRU/Com53K+KFtDKPUdBHZnuENrZrQ+8RU59vdLrHwsCvP9elJFkcX9xk/r45oUGXhqVV3vMyaqTa9YUO772rhgKuAi4TqiaR51H58KWqynp7wOZwL5FqJs0KzL5rNDDIoKKrklnOidS4RAUKXCi1CUNXwDdOo4Kd96cYOIHqpwa7Beci8CtVlzd/49yE9/AXnZYVwp10uKZvJJdliAOHhVEAtCIp8PzHOOPYJsXvUcEU4ORWWWpusBAz6wFiLOL4d/CAHNj6wDFliRexBrv/Wunu5ifva4oVJWrtAtyGDtsX8kBkf8OcIdy/aPUIIBrbW1sapjPFymMGeL/KkSZRjEy7KjFZKZh9L7sJE56sq+IUremFbcyaX1E3rho6Cs3ongLaKhL9f9vz8EFs7//w8pNlNS9EUdOU68=
+
+before_install:
+- export LANG=en_US.UTF-8
+- brew update
+
+install:
+- npm install
+- brew install gradle
+- wget http://dl.google.com/android/android-sdk_r24.4-macosx.zip
+- tar -xvf android-sdk_r24.4-macosx.zip
+- echo y | ./android-sdk-macosx/tools/android update sdk --no-ui --all --filter platform-tools
+- echo y | ./android-sdk-macosx/tools/android update sdk --no-ui --all --filter build-tools-25.0.0
+- echo y | ./android-sdk-macosx/tools/android update sdk --no-ui --all --filter android-25
+- echo y | ./android-sdk-macosx/tools/android update sdk --no-ui --all --filter extra-android-support
+- echo y | ./android-sdk-macosx/tools/android update sdk --no-ui --all --filter extra-android-m2repository
+- echo y | ./android-sdk-macosx/tools/android update sdk --no-ui --all --filter extra-google-m2repository
+- export ANDROID_HOME=./android-sdk-macosx
+- export PATH=${PATH}:$ANDROID_HOME/tools:$ANDROID_HOME/platform-tools:$ANDROID_HOME/build-tools/23.0.2
+
+script:
+- travis_wait scripts/build-test-app.sh
+- scripts/upload-artifact.sh
+- scripts/test.sh --ios --emulator
+
+after_success:
+
+deploy:
+
 notifications:
   slack:
     secure: lXE+2AgsxZU5G5dI91LkMAIgo8MAWfdM7DB5UOtn5LpuNln+2FmJo1gOI7tkdmLOqpXTGYnpI2VyQN3H4nOF21YhuouzD1Sh8n2wtQg1iTm353kuQpqiVhSBX8ZJ7Be1e1G8OsnxoYOxbs4Zo9qI40EruwkvqLCBHWM5MRGyd4M7EFWwb9Z29VZN0y1Nt5g/c3bT76kdKmF+JCLur2OeEKxAity7sIKgZekSqeIMwEVLSxXnda6Dbjc/cg0MJ0iDArkD7iu6fz/Fcrrxgm/pUxjcgvqze7Gy5i31mjEfspnrglWV1cshMd48BTDKCJ2AMmxH8O3GPSWE2txjIvGRWUve7iViNylvmQCVz3Eyf99+4EuuVGa+5PSodQ/CqODx/65EwtcN3PE1tNz2puKOK8nrOJcFkcbG8KTHKUlQtHCkjitbykUnj/hvhLK5/oWlQYVOLWWrHwdGUh8FI8aFPVGjRjWbHbhdayjEIqxwr1ns+6mYrP1EFNXbaeZxnLNC59XpJl1ifuezqYAk7YEiU5j4rtC7YKgyQ3ueb7anOHTJoTMyDn8mpZXgwuyhoBaeEYytQVgRyMtL6Y5cP98Jn2kv0+vdne3rkk9/JEBTo32HOjvoij6rsqEvXC0LhUDJSNadOVdHht0jjoN6zBH37HIE5/3zysLlPcAcHAS83ow=

CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## v1.6.2
+
+- Change #29: removed "validateDomainName" (see info notice)
+- Fixed #31: request fails throwing error on erroneous cookies
+- Fixed #28: added support for content type "application/hal+json" on iOS (thanks ryandegruyter)
+
+#### Important information
+We've decided to remove the `validateDomainName()` method, because people were complaining that `acceptAllCerts(true)` is not behaving as expected. And also it's not a good idea to disable domain name validation while using valid certs, because it pretends having a secure connection, but it isn't.
+
+You should either use valid certs with domain name validation enabled (safe for production use) or accept any certs without domain name validation (only for private dev environments). I strongly discourage using fake certs in public networks.
+
+Therefore we are disabling domain name validation automatically, when you set `acceptAllCerts(true)`. So if you were using `validateDomainName()` function, you need to remove this function call for v1.6.2+.
+
 ## v1.6.1
 
 - Fixed #23: PATCH method broken on android

README.md

@@ -1,7 +1,11 @@
 Cordova Advanced HTTP
 =====================
+[![npm version](https://badge.fury.io/js/cordova-plugin-advanced-http.svg)](https://badge.fury.io/js/cordova-plugin-advanced-http)
+[![downloads/month](https://img.shields.io/npm/dm/cordova-plugin-advanced-http.svg)](https://www.npmjs.com/package/cordova-plugin-advanced-http)
+[![MIT Licence](https://badges.frapsoft.com/os/mit/mit.png)](https://opensource.org/licenses/mit-license.php)
 [![Build Status](https://travis-ci.org/silkimen/cordova-plugin-advanced-http.svg?branch=master)](https://travis-ci.org/silkimen/cordova-plugin-advanced-http)
 
+
 Cordova / Phonegap plugin for communicating with HTTP servers.  Supports iOS and Android.
 This is a fork of [Wymsee's Cordova-HTTP plugin](https://github.com/wymsee/cordova-HTTP).
 
@@ -108,13 +112,7 @@ Accept all SSL certificates.  Or disable accepting all certificates.  This defau
     });
 
 ### validateDomainName
-Whether or not to validate the domain name in the certificate.  This defaults to true.
-
-    cordovaHTTP.validateDomainName(false, function() {
-        console.log('success!');
-    }, function() {
-        console.log('error :(');
-    });
+This function was removed in v1.6.2. Domain name validation is disabled automatically when you enable "acceptAllCerts".
 
 ### removeCookies
 Remove all cookies associated with a given URL.
@@ -227,4 +225,4 @@ This plugin utilizes some awesome open source networking libraries. These are bo
  - iOS - [AFNetworking](https://github.com/AFNetworking/AFNetworking)
  - Android - [http-request](https://github.com/kevinsawicki/http-request)
 
-We made a few modifications to http-request.
+We made a few modifications to both of them.

package.json

@@ -1,9 +1,10 @@
 {
   "name": "cordova-plugin-advanced-http",
-  "version": "1.6.1",
+  "version": "1.6.2",
   "description": "Cordova / Phonegap plugin for communicating with HTTP servers using SSL pinning",
   "scripts": {
-    "test": "./scripts/test-installation.sh"
+    "test": "./scripts/build-test-app.sh && ./scripts/test.sh --ios --emulator",
+    "release": "npm run test && ./scripts/release.sh"
   },
   "cordova": {
     "id": "cordova-plugin-advanced-http",
@@ -49,9 +50,14 @@
   },
   "homepage": "https://github.com/silkimen/cordova-plugin-advanced-http#readme",
   "devDependencies": {
+    "chai": "4.1.2",
+    "chai-as-promised": "7.1.1",
+    "colors": "1.1.2",
     "cordova": "7.0.1",
+    "mocha": "4.0.0",
     "mz": "2.7.0",
     "umd-tough-cookie": "2.3.2",
+    "wd": "1.4.1",
     "xml2js": "0.4.19"
   }
 }

plugin.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<plugin xmlns="http://www.phonegap.com/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android" id="cordova-plugin-advanced-http" version="1.6.1">
+<plugin xmlns="http://www.phonegap.com/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android" id="cordova-plugin-advanced-http" version="1.6.2">
   <name>Advanced HTTP plugin</name>
   <description>
         Cordova / Phonegap plugin for communicating with HTTP servers using SSL pinning

scripts/build-test-app.sh

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+set -e
+
+PLATFORM=$([[ "${@#--android}" = "$@" ]] && echo "ios" || echo "android")
+TARGET=$([[ "${@#--device}" = "$@" ]] && echo "emulator" || echo "device")
+ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"/..
+CDV=$ROOT/node_modules/.bin/cordova
+
+rm -rf $ROOT/temp
+mkdir $ROOT/temp
+cp -r $ROOT/test/app-template/ $ROOT/temp/
+cp $ROOT/test/test-definitions.js $ROOT/temp/www/js/
+cd $ROOT/temp
+$CDV prepare
+$CDV plugins add $ROOT
+$CDV build $PLATFORM --$TARGET

scripts/release.sh

@@ -1,9 +1,13 @@
 #!/usr/bin/env bash
 set -e
 
-VERSION=$(node -e "console.log(require('./package.json').version)")
+ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"/..
 
+pushd $ROOT
+VERSION=$(node -e "console.log(require('./package.json').version)")
 ./scripts/update-tough-cookie.sh
 node ./scripts/update-plugin-xml.js $VERSION
-npm publish
+git commit -a -m "release v$VERSION"
 git tag "v$VERSION"
+npm publish
+popd

scripts/test-installation.sh

@@ -1,12 +0,0 @@
-#!/usr/bin/env bash
-set -e
-
-ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"/..
-CDV=$ROOT/node_modules/.bin/cordova
-
-rm -rf $ROOT/temp
-$CDV create $ROOT/temp
-cd $ROOT/temp
-$CDV platforms add android
-$CDV platforms add ios
-$CDV plugins add $ROOT

scripts/test.sh

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+set -e
+
+ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"/..
+
+pushd $ROOT
+./node_modules/.bin/mocha ./test/mocha-specs/test.js "$@"
+popd

scripts/upload-artifact.sh

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+set -e
+
+ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"/..
+TEMP=$ROOT/temp
+
+rm -rf $TEMP/HttpDemo.app.zip
+pushd $TEMP/platforms/ios/build/emulator
+zip -r $TEMP/HttpDemo.app.zip ./HttpDemo.app
+popd
+
+curl -u $SAUCE_USERNAME:$SAUCE_ACCESS_KEY \
+    -X POST \
+    -H "Content-Type: application/octet-stream" \
+    https://saucelabs.com/rest/v1/storage/$SAUCE_USERNAME/HttpDemo.app.zip?overwrite=true \
+    --data-binary @$TEMP/HttpDemo.app.zip

src/android/com/synconset/cordovahttp/CordovaHttpPlugin.java

@@ -99,11 +99,7 @@ public class CordovaHttpPlugin extends CordovaPlugin {
             boolean accept = args.getBoolean(0);
 
             CordovaHttp.acceptAllCerts(accept);
-            callbackContext.success();
-        } else if (action.equals("validateDomainName")) {
-            boolean accept = args.getBoolean(0);
-
-            CordovaHttp.validateDomainName(accept);
+            CordovaHttp.validateDomainName(!accept);
             callbackContext.success();
         } else if (action.equals("uploadFile")) {
             String urlString = args.getString(0);

src/ios/CordovaHttpPlugin.h

@@ -6,7 +6,6 @@
 
 - (void)enableSSLPinning:(CDVInvokedUrlCommand*)command;
 - (void)acceptAllCerts:(CDVInvokedUrlCommand*)command;
-- (void)validateDomainName:(CDVInvokedUrlCommand*)command;
 - (void)disableRedirect:(CDVInvokedUrlCommand*)command;
 - (void)post:(CDVInvokedUrlCommand*)command;
 - (void)get:(CDVInvokedUrlCommand*)command;

src/ios/CordovaHttpPlugin.m

@@ -108,6 +108,7 @@
 
 - (void)enableSSLPinning:(CDVInvokedUrlCommand*)command {
     bool enable = [[command.arguments objectAtIndex:0] boolValue];
+
     if (enable) {
         securityPolicy = [AFSecurityPolicy policyWithPinningMode:AFSSLPinningModeCertificate];
     } else {
@@ -133,16 +134,7 @@
     bool allow = [[command.arguments objectAtIndex:0] boolValue];
 
     securityPolicy.allowInvalidCertificates = allow;
-
-    pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
-    [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
-}
-
-- (void)validateDomainName:(CDVInvokedUrlCommand*)command {
-    CDVPluginResult* pluginResult = nil;
-    bool validate = [[command.arguments objectAtIndex:0] boolValue];
-
-    securityPolicy.validatesDomainName = validate;
+    securityPolicy.validatesDomainName = !allow;
 
     pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
     [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];

src/ios/TextResponseSerializer.m

@@ -23,7 +23,7 @@ static BOOL AFErrorOrUnderlyingErrorHasCodeInDomain(NSError *error, NSInteger co
         return nil;
     }
 
-    self.acceptableContentTypes = [NSSet setWithObjects:@"text/plain", @"text/html", @"text/json", @"application/json", @"text/xml", @"application/xml", @"text/css", nil];
+    self.acceptableContentTypes = [NSSet setWithObjects:@"text/plain", @"text/html", @"text/json", @"application/hal+json", @"application/json", @"text/xml", @"application/xml", @"text/css", nil];
 
     return self;
 }
@@ -55,4 +55,4 @@ static BOOL AFErrorOrUnderlyingErrorHasCodeInDomain(NSError *error, NSInteger co
     return responseString;
 }
 
-@end
+@end

test/app-template/config.xml

@@ -0,0 +1,27 @@
+<?xml version='1.0' encoding='utf-8'?>
+<widget id="com.ilkimen.http.demo" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
+    <name>HttpDemo</name>
+    <description>
+        A sample Apache Cordova application that demonstrates advanced HTTP plugin.
+    </description>
+    <author email="dev@cordova.apache.org" href="http://cordova.io">
+        Sefa Ilkimen
+    </author>
+    <content src="index.html" />
+    <access origin="*" />
+    <allow-intent href="http://*/*" />
+    <allow-intent href="https://*/*" />
+    <allow-intent href="tel:*" />
+    <allow-intent href="sms:*" />
+    <allow-intent href="mailto:*" />
+    <allow-intent href="geo:*" />
+    <platform name="android">
+        <allow-intent href="market:*" />
+    </platform>
+    <platform name="ios">
+        <allow-intent href="itms:*" />
+        <allow-intent href="itms-apps:*" />
+    </platform>
+    <engine name="android" spec="6.2.3" />
+    <engine name="ios" spec="4.4.0" />
+</widget>

test/app-template/package.json

@@ -0,0 +1,25 @@
+{
+    "name": "com.ilkimen.http.demo",
+    "displayName": "HttpDemo",
+    "version": "1.0.0",
+    "description": "A sample Apache Cordova application that demonstrates advanced HTTP plugin.",
+    "main": "index.js",
+    "scripts": {
+        "build": "scripts/build.sh",
+        "test": "npm run build && scripts/test.sh"
+    },
+    "author": "Sefa Ilkimen",
+    "license": "Apache-2.0",
+    "dependencies": {
+        "cordova": "7.0.1",
+        "cordova-android": "6.2.3",
+        "cordova-ios": "4.4.0"
+    },
+    "cordova": {
+        "platforms": [
+            "android",
+            "ios"
+        ]
+    },
+    "devDependencies": {}
+}

test/app-template/www/css/index.css

@@ -0,0 +1,24 @@
+* {
+    -webkit-tap-highlight-color: rgba(0,0,0,0); /* make transparent link selection, adjust last value opacity 0 to 1.0 */
+}
+
+body {
+    -webkit-touch-callout: none;                /* prevent callout to copy image, etc when tap to hold */
+    -webkit-text-size-adjust: none;             /* prevent webkit from resizing text to fit */
+    -webkit-user-select: none;                  /* prevent copy paste, to allow, change 'none' to 'text' */
+    height:100%;
+    margin:0px;
+    padding:20px 0;
+    width:100%;
+    font-family: sans-serif;
+}
+
+button, input, textarea {
+  display: block;
+  width: 100%;
+}
+
+h1 {
+  font-size: 12pt;
+  text-align: center;
+}

test/app-template/www/index.html

@@ -0,0 +1,20 @@
+<!DOCTYPE html>
+<html>
+    <head>
+        <meta http-equiv="Content-Security-Policy" content="default-src 'self' data: gap: https://ssl.gstatic.com 'unsafe-eval'; style-src 'self' 'unsafe-inline'; media-src *; img-src 'self' data: content:;">
+        <meta name="format-detection" content="telephone=no">
+        <meta name="msapplication-tap-highlight" content="no">
+        <meta name="viewport" content="user-scalable=no, initial-scale=1, maximum-scale=1, minimum-scale=1, width=device-width">
+        <link rel="stylesheet" type="text/css" href="css/index.css">
+    </head>
+    <body>
+        <h1 id="descriptionLbl">Advanced HTTP test suite</h1>
+        <textarea rows="16" cols="50" id="expectedTextarea">Click next to run first test.</textarea>
+        <textarea rows="16" cols="50" id="resultTextarea"></textarea>
+        <button id="nextBtn">Run next test</button>
+
+        <script type="text/javascript" src="cordova.js"></script>
+        <script type="text/javascript" src="js/test-definitions.js"></script>
+        <script type="text/javascript" src="js/index.js"></script>
+    </body>
+</html>

test/app-template/www/js/index.js

@@ -0,0 +1,71 @@
+const app = {
+  testIndex: -1,
+
+  initialize: function() {
+    document.getElementById('nextBtn').addEventListener('click', app.onNextBtnClick);
+  },
+
+  printResult: function(prefix, content) {
+    const text = prefix + ': ' + JSON.stringify(content);
+
+    document.getElementById('resultTextarea').value += text;
+  },
+
+  reject: function(content) {
+    app.printResult('result - rejected', content);
+  },
+
+  resolve: function(content) {
+    app.printResult('result - resolved', content);
+  },
+
+  runTest: function(index) {
+    const testDefinition = tests[index];
+    const titleText = app.testIndex + ': ' + testDefinition.description;
+    const expectedText = 'expected - ' + testDefinition.expected;
+
+    document.getElementById('expectedTextarea').value = expectedText;
+    document.getElementById('resultTextarea').value = '';
+    document.getElementById('descriptionLbl').innerText = titleText;
+    testDefinition.func(app.resolve, app.reject);
+  },
+
+  onBeforeTest: function(testIndex, cb) {
+    if (hooks && hooks.onBeforeEachTest) {
+      return hooks.onBeforeEachTest(function() {
+        const testDefinition = tests[testIndex];
+
+        if (testDefinition.before) {
+          testDefinition.before(cb);
+        } else {
+          cb();
+        }
+      });
+    } else {
+      cb();
+    }
+  },
+
+  onFinishedAllTests: function() {
+    const titleText = 'No more tests';
+    const expectedText = 'You have run all available tests.';
+
+    document.getElementById('expectedTextarea').value = expectedText;
+    document.getElementById('resultTextarea').value = '';
+    document.getElementById('descriptionLbl').innerText = titleText;
+  },
+
+  onNextBtnClick: function() {
+    app.testIndex += 1;
+
+    if (app.testIndex < tests.length) {
+      app.onBeforeTest(app.testIndex, function() {
+        app.runTest(app.testIndex);
+      });
+    } else {
+      app.onFinishedAllTests();
+    }
+  }
+};
+
+app.initialize();

test/mocha-specs/helpers/apps.js

@@ -0,0 +1,10 @@
+const path = require('path');
+
+if (process.env.SAUCE_USERNAME) {
+  exports.iosTestApp = 'sauce-storage:HttpDemo.app.zip';
+  exports.androidTestApp = 'sauce-storage:HttpDemo.apk';
+} else {
+  // these paths are relative to working directory
+  exports.iosTestApp = path.resolve('temp/platforms/ios/build/emulator/HttpDemo.app');
+  exports.androidTestApp = path.resolve('temp/platforms/android/build/outputs/apk/android-debug.apk');
+}

test/mocha-specs/helpers/caps.js

@@ -0,0 +1,65 @@
+const local = {
+  iosDevice: {
+    browserName: '',
+    'appium-version': '1.7.1',
+    platformName: 'iOS',
+    platformVersion: '10.3',
+    deviceName: 'iPhone 6',
+    autoWebview: true,
+    app: undefined // will be set later
+  },
+  iosEmulator: {
+    browserName: '',
+    'appium-version': '1.7.1',
+    platformName: 'iOS',
+    platformVersion: '11.0',
+    deviceName: 'iPhone Simulator',
+    autoWebview: true,
+    app: undefined // will be set later
+  },
+  androidEmulator: {
+    browserName: '',
+    'appium-version': '1.7.1',
+    platformName: 'Android',
+    platformVersion: '5.1',
+    deviceName: 'Android Emulator',
+    autoWebview: true,
+    app: undefined // will be set later
+  }
+};
+
+const sauce = {
+  iosDevice: {
+    browserName: '',
+    'appium-version': '1.7.1',
+    platformName: 'iOS',
+    platformVersion: '10.3',
+    deviceName: 'iPhone 6',
+    autoWebview: true,
+    app: undefined // will be set later
+  },
+  iosEmulator: {
+    browserName: '',
+    'appium-version': '1.7.1',
+    platformName: 'iOS',
+    platformVersion: '10.3',
+    deviceName: 'iPhone Simulator',
+    autoWebview: true,
+    app: undefined // will be set later
+  },
+  androidEmulator: {
+    browserName: '',
+    'appium-version': '1.7.1',
+    platformName: 'Android',
+    platformVersion: '5.1',
+    deviceName: 'Android Emulator',
+    autoWebview: true,
+    app: undefined // will be set later
+  }
+};
+
+if (process.env.SAUCE_USERNAME) {
+  module.exports = sauce;
+} else {
+  module.exports = local;
+}

test/mocha-specs/helpers/logging.js

@@ -0,0 +1,13 @@
+exports.configure = driver => {
+  driver.on('status', info => {
+    console.log(info.cyan);
+  });
+
+  driver.on('command', (meth, path, data) => {
+    console.log(' > ' + meth.yellow, path.grey, data || '');
+  });
+
+  driver.on('http', (meth, path, data) => {
+    console.log(' > ' + meth.magenta, path, (data || '').grey);
+  });
+};

test/mocha-specs/helpers/server.js

@@ -0,0 +1,16 @@
+const local = {
+  host: 'localhost',
+  port: 4723
+};
+
+const sauce = {
+  host: 'ondemand.saucelabs.com',
+  port: 80,
+  auth: process.env.SAUCE_USERNAME + ":" + process.env.SAUCE_ACCESS_KEY
+};
+
+if (process.env.SAUCE_USERNAME) {
+  module.exports = sauce;
+} else {
+  module.exports = local;
+}

test/mocha-specs/helpers/setup.js

@@ -0,0 +1,12 @@
+const wd = require("wd");
+
+require('colors');
+
+const chai = require('chai');
+const chaiAsPromised = require('chai-as-promised');
+chai.use(chaiAsPromised);
+
+const should = chai.should();
+chaiAsPromised.transferPromiseness = wd.transferPromiseness;
+
+exports.should = should;

test/mocha-specs/test.js

@@ -0,0 +1,73 @@
+require('./helpers/setup');
+
+const wd = require('wd');
+const apps = require('./helpers/apps');
+const caps = Object.assign({}, require('./helpers/caps'));
+const serverConfig = require('./helpers/server');
+const testDefinitions = require('../test-definitions');
+const pkgjson = require('../../package.json');
+
+describe('Advanced HTTP', function() {
+  let driver;
+  let allPassed = true;
+
+  this.timeout(900000);
+
+  const getCaps = appName => {
+    const isDevice = process.argv.includes('--device');
+    const isAndroid = process.argv.includes('--android');
+    const desiredCaps = caps[(isAndroid ? 'android' : 'ios') + (isDevice ? 'Device' : 'Emulator')];
+    const desiredApp = apps[(isAndroid ? 'android' : 'ios') + appName];
+
+    desiredCaps.name = pkgjson.name;
+    desiredCaps.app = desiredApp;
+
+    return desiredCaps;
+  };
+
+  const validateTestIndex = number => driver
+    .elementById('descriptionLbl')
+    .text()
+    .then(text => parseInt(text.match(/(\d+):/)[1], 10))
+    .should.eventually.become(number, 'Test index is not matching!');
+
+  const validateTestTitle = testTitle => driver
+    .elementById('descriptionLbl')
+    .text()
+    .then(text => text.match(/\d+:\ (.*)/)[1])
+    .should.eventually.become(testTitle, 'Test description is not matching!');
+
+  const validateResult = text => driver
+    .elementById('resultTextarea')
+    .getAttribute('value')
+    .should.eventually.include(text);
+
+  const clickNext = () => driver
+    .elementById('nextBtn')
+    .click()
+    .sleep(1000);
+
+  before(() => {
+    driver = wd.promiseChainRemote(serverConfig);
+    require('./helpers/logging').configure(driver);
+
+    return driver.init(getCaps('TestApp'));
+  });
+
+  after(() => driver
+    .quit()
+    .finally(function () {
+      if (process.env.SAUCE_USERNAME) {
+        return driver.sauceJobStatus(allPassed);
+      }
+    }));
+
+  testDefinitions.tests.forEach((definition, index) => {
+    it(definition.description, function() {
+      return clickNext()
+        .then(() => validateTestIndex(index))
+        .then(() => validateTestTitle(this.test.title))
+        .then(() => validateResult(definition.expected))
+      });
+  });
+});

test/test-definitions.js

@@ -0,0 +1,67 @@
+const hooks = {
+  onBeforeEachTest: function(done) {
+    cordova.plugin.http.acceptAllCerts(false, done, done);
+  }
+};
+
+const helpers = {
+  acceptAllCerts: function(done) { cordova.plugin.http.acceptAllCerts(true, done, done); }
+};
+
+const tests = [
+  {
+    description: 'should reject self signed cert (GET)',
+    expected: 'rejected: {"status":-1,"error":"cancelled"}',
+    func: function(resolve, reject) { cordova.plugin.http.get('https://self-signed.badssl.com/', {}, {}, resolve, reject); }
+  },{
+    description: 'should reject self signed cert (PUT)',
+    expected: 'rejected: {"status":-1,"error":"cancelled"}',
+    func: function(resolve, reject) { cordova.plugin.http.put('https://self-signed.badssl.com/', { test: 'testString' }, {}, resolve, reject); }
+  },{
+    description: 'should reject self signed cert (POST)',
+    expected: 'rejected: {"status":-1,"error":"cancelled"}',
+    func: function(resolve, reject) { cordova.plugin.http.post('https://self-signed.badssl.com/', { test: 'testString' }, {}, resolve, reject); }
+  },{
+    description: 'should reject self signed cert (PATCH)',
+    expected: 'rejected: {"status":-1,"error":"cancelled"}',
+    func: function(resolve, reject) { cordova.plugin.http.patch('https://self-signed.badssl.com/', { test: 'testString' }, {}, resolve, reject); }
+  },{
+    description: 'should reject self signed cert (DELETE)',
+    expected: 'rejected: {"status":-1,"error":"cancelled"}',
+    func: function(resolve, reject) { cordova.plugin.http.delete('https://self-signed.badssl.com/', {}, {}, resolve, reject); }
+  },{
+    description: 'should accept bad cert (GET)',
+    expected: 'resolved: {\"status\":200,',
+    before: helpers.acceptAllCerts,
+    func: function(resolve, reject) { cordova.plugin.http.get('https://self-signed.badssl.com/', {}, {}, resolve, reject); }
+  },{
+    description: 'should accept bad cert (PUT)',
+    expected: 'rejected: {\"status\":405,', // will be rejected because PUT is not allowed
+    before: helpers.acceptAllCerts,
+    func: function(resolve, reject) { cordova.plugin.http.put('https://self-signed.badssl.com/', { test: 'testString' }, {}, resolve, reject); }
+  },{
+    description: 'should accept bad cert (POST)',
+    expected: 'rejected: {\"status\":405,', // will be rejected because POST is not allowed
+    before: helpers.acceptAllCerts,
+    func: function(resolve, reject) { cordova.plugin.http.post('https://self-signed.badssl.com/', { test: 'testString' }, {}, resolve, reject); }
+  },{
+    description: 'should accept bad cert (PATCH)',
+    expected: 'rejected: {\"status\":405,', // will be rejected because PATCH is not allowed
+    before: helpers.acceptAllCerts,
+    func: function(resolve, reject) { cordova.plugin.http.patch('https://self-signed.badssl.com/', { test: 'testString' }, {}, resolve, reject); }
+  },{
+    description: 'should accept bad cert (DELETE)',
+    expected: 'rejected: {\"status\":405,', // will be rejected because DELETE is not allowed
+    before: helpers.acceptAllCerts,
+    func: function(resolve, reject) { cordova.plugin.http.delete('https://self-signed.badssl.com/', {}, {}, resolve, reject); }
+  },{
+    description: 'should fetch data from http://google.com/ (GET)',
+    expected: 'resolved: {\"status\":200,',
+    before: helpers.acceptAllCerts,
+    func: function(resolve, reject) { cordova.plugin.http.get('http://google.com/', {}, {}, resolve, reject); }
+  }
+];
+
+if (module && module.exports) {
+  module.exports = { tests: tests, hooks: hooks };
+}

www/advanced-http.js

@@ -157,10 +157,10 @@ var http = {
         return exec(success, failure, 'CordovaHttpPlugin', 'acceptAllCerts', [allow]);
     },
     disableRedirect: function(disable, success, failure) {
-        return exec(success, failure, "CordovaHttpPlugin", "disableRedirect", [disable]);
+        return exec(success, failure, 'CordovaHttpPlugin', 'disableRedirect', [disable]);
     },
     validateDomainName: function (validate, success, failure) {
-        return exec(success, failure, 'CordovaHttpPlugin', 'validateDomainName', [validate]);
+        failure('advanced-http: "validateDomainName" is no more supported, please see change log for further info');
     },
     post: function (url, data, headers, success, failure) {
         handleMissingCallbacks(success, failure);

www/cookie-handler.js

@@ -41,7 +41,7 @@ function setCookieFromString(url, cookieStr) {
     var cookies = splitCookieString(cookieStr);
 
     for (var i = 0; i < cookies.length; ++i) {
-        cookieJar.setCookieSync(cookies[i], url);
+        cookieJar.setCookieSync(cookies[i], url, { ignoreError: true });
     }
 }